Re: [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix

Vinod Koul
2022-08-30T07:28:32Z

On 30-08-22, 09:01, Johan Hovold wrote:
> On Tue, Aug 30, 2022 at 10:36:43AM +0530, Vinod Koul wrote:
> > On 14-07-22, 14:43, Johan Hovold wrote:
> > > When adding support for SC8280XP to the QMP PHY driver I noticed that
> > > the PHY provider child node was not described by the current DT schema.
> > >
> > > The SC8280XP PHYs also need a second fixed-divider PIPE clock
> > > ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to
> > > the clock name just to match the current "pipe0" name so I decided to
> > > deprecate the unnecessary suffix in the current binding instead.
> > >
> > > To be able to add the missing child-node schema and handle device
> > > specifics like additional PIPE clocks, it quickly became obvious that
> > > the binding needs to be split up.
> > >
> > > This series clean up and fixes some issue with the current schema before
> > > splitting it up in separate schemas for PCIe, UFS and USB and adding
> > > missing parts like the child PHY provider nodes.
> > >
> > > The MSM8996 PCIe PHY gets its own schema as this is the only non-combo
> > > PHY that actually provides more than one PHY per IP block. Note that the
> > > "lane" suffix is still unnecessary and misleading.
> > >
> > > The final patches add support for the updated binding to the (recently
> > > split up) PHY drivers. Included is also a related combo PHY cleanup.
> >
> > This fails at patch 2 for me on v6.0-rc1, please rebase and resend
>
> Are you sure you haven't applied anything to your local tree that causes
> this?

Pretty sure :-)

>
> I just tried fetching the v3 series from lore and it applies just fine
> on top of 6.0-rc1.
>
> Note that if you've added a new compatible string locally, the second
> patch which sorts the compatible strings is likely to fail to apply.

At that time no, now I think I have patch or so ... Tree should be
pushed in a bit, you can check

--
~Vinod