public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Chen <peter.chen@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: [for-next][PATCH 11/23] usb: chipidea: tracing: Use the new __vstring() helper
Date: Thu, 14 Jul 2022 12:43:07 -0400	[thread overview]
Message-ID: <20220714164329.940280500@goodmis.org> (raw)
In-Reply-To: 20220714164256.403842845@goodmis.org

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

Instead of open coding a __dynamic_array() with a fixed length (which
defeats the purpose of the dynamic array in the first place). Use the new
__vstring() helper that will use a va_list and only write enough of the
string into the ring buffer that is needed.

Link: https://lkml.kernel.org/r/20220705224749.991587733@goodmis.org

Cc: Peter Chen <peter.chen@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 drivers/usb/chipidea/trace.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/chipidea/trace.h b/drivers/usb/chipidea/trace.h
index 1601fd86c4c1..ca0e65b48f0a 100644
--- a/drivers/usb/chipidea/trace.h
+++ b/drivers/usb/chipidea/trace.h
@@ -28,11 +28,11 @@ TRACE_EVENT(ci_log,
 	TP_ARGS(ci, vaf),
 	TP_STRUCT__entry(
 		__string(name, dev_name(ci->dev))
-		__dynamic_array(char, msg, CHIPIDEA_MSG_MAX)
+		__vstring(msg, vaf->fmt, vaf->va)
 	),
 	TP_fast_assign(
 		__assign_str(name, dev_name(ci->dev));
-		vsnprintf(__get_str(msg), CHIPIDEA_MSG_MAX, vaf->fmt, *vaf->va);
+		__assign_vstr(msg, vaf->fmt, vaf->va);
 	),
 	TP_printk("%s: %s", __get_str(name), __get_str(msg))
 );
-- 
2.35.1

  parent reply	other threads:[~2022-07-14 16:44 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 16:42 [for-next][PATCH 00/23] tracing: Updates for 5.20 Steven Rostedt
2022-07-14 16:42 ` [for-next][PATCH 01/23] tracing/user_events: Fix syntax errors in comments Steven Rostedt
2022-07-14 16:42 ` [for-next][PATCH 02/23] tracing/histograms: Simplify create_hist_fields() Steven Rostedt
2022-07-14 16:42 ` [for-next][PATCH 03/23] tracing: devlink: Use static array for string in devlink_trap_report even Steven Rostedt
2022-07-14 18:40   ` Ido Schimmel
2022-07-14 19:05     ` Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 04/23] tracing/ipv4/ipv6: Use static array for name field in fib*_lookup_table event Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 05/23] neighbor: tracing: Have neigh_create event use __string() Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 06/23] tracing/events: Add __vstring() and __assign_vstr() helper macros Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 07/23] tracing/IB/hfi1: Use the new __vstring() helper Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 08/23] tracing/ath: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 09/23] tracing/brcm: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 10/23] tracing/iwlwifi: " Steven Rostedt
2022-07-14 16:43 ` Steven Rostedt [this message]
2022-07-14 16:43 ` [for-next][PATCH 12/23] xhci: tracing: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 13/23] USB: mtu3: " Steven Rostedt
2022-07-15  6:32   ` Chunfeng Yun
2022-07-15 21:39     ` Steven Rostedt
2022-07-19  5:23       ` Chunfeng Yun
2022-07-19 15:24         ` Steven Rostedt
2022-07-15 10:01   ` Chunfeng Yun
2022-07-15 14:36     ` Steven Rostedt
2022-07-15 21:24     ` Steven Rostedt
2022-07-19  5:18       ` Chunfeng Yun
2022-07-14 16:43 ` [for-next][PATCH 14/23] usb: musb: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 15/23] scsi: iscsi: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 16/23] scsi: qla2xxx: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 17/23] batman-adv: " Steven Rostedt
2022-07-24 21:31   ` Sven Eckelmann
2022-07-24 23:12     ` Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 18/23] mac80211: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 19/23] tracing: eprobe: Add missing log index Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 20/23] tracing: eprobe: Remove duplicate is_good_name() operation Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 21/23] tracing: Auto generate event name when creating a group of events Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 22/23] selftests/ftrace: Add test case for GRP/ only input Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 23/23] selftests/kprobe: Do not test for GRP/ without event failures Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220714164329.940280500@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peter.chen@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox