From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Tom Zanussi <zanussi@kernel.org>,
Linyu Yuan <quic_linyyuan@quicinc.com>
Subject: [for-next][PATCH 20/23] tracing: eprobe: Remove duplicate is_good_name() operation
Date: Thu, 14 Jul 2022 12:43:16 -0400 [thread overview]
Message-ID: <20220714164331.609693610@goodmis.org> (raw)
In-Reply-To: 20220714164256.403842845@goodmis.org
From: Linyu Yuan <quic_linyyuan@quicinc.com>
traceprobe_parse_event_name() already validate SYSTEM and EVENT name,
there is no need to call is_good_name() after it.
Link: https://lore.kernel.org/all/1656296348-16111-3-git-send-email-quic_linyyuan@quicinc.com/
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/trace/trace_eprobe.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index b805b570305f..8979cb9ec37a 100644
--- a/kernel/trace/trace_eprobe.c
+++ b/kernel/trace/trace_eprobe.c
@@ -887,8 +887,6 @@ static int __trace_eprobe_create(int argc, const char *argv[])
sys_event - argv[1]);
if (ret || !sys_name)
goto parse_error;
- if (!is_good_name(sys_event) || !is_good_name(sys_name))
- goto parse_error;
mutex_lock(&event_mutex);
event_call = find_and_get_event(sys_name, sys_event);
--
2.35.1
next prev parent reply other threads:[~2022-07-14 16:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 16:42 [for-next][PATCH 00/23] tracing: Updates for 5.20 Steven Rostedt
2022-07-14 16:42 ` [for-next][PATCH 01/23] tracing/user_events: Fix syntax errors in comments Steven Rostedt
2022-07-14 16:42 ` [for-next][PATCH 02/23] tracing/histograms: Simplify create_hist_fields() Steven Rostedt
2022-07-14 16:42 ` [for-next][PATCH 03/23] tracing: devlink: Use static array for string in devlink_trap_report even Steven Rostedt
2022-07-14 18:40 ` Ido Schimmel
2022-07-14 19:05 ` Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 04/23] tracing/ipv4/ipv6: Use static array for name field in fib*_lookup_table event Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 05/23] neighbor: tracing: Have neigh_create event use __string() Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 06/23] tracing/events: Add __vstring() and __assign_vstr() helper macros Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 07/23] tracing/IB/hfi1: Use the new __vstring() helper Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 08/23] tracing/ath: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 09/23] tracing/brcm: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 10/23] tracing/iwlwifi: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 11/23] usb: chipidea: tracing: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 12/23] xhci: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 13/23] USB: mtu3: " Steven Rostedt
2022-07-15 6:32 ` Chunfeng Yun
2022-07-15 21:39 ` Steven Rostedt
2022-07-19 5:23 ` Chunfeng Yun
2022-07-19 15:24 ` Steven Rostedt
2022-07-15 10:01 ` Chunfeng Yun
2022-07-15 14:36 ` Steven Rostedt
2022-07-15 21:24 ` Steven Rostedt
2022-07-19 5:18 ` Chunfeng Yun
2022-07-14 16:43 ` [for-next][PATCH 14/23] usb: musb: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 15/23] scsi: iscsi: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 16/23] scsi: qla2xxx: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 17/23] batman-adv: " Steven Rostedt
2022-07-24 21:31 ` Sven Eckelmann
2022-07-24 23:12 ` Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 18/23] mac80211: " Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 19/23] tracing: eprobe: Add missing log index Steven Rostedt
2022-07-14 16:43 ` Steven Rostedt [this message]
2022-07-14 16:43 ` [for-next][PATCH 21/23] tracing: Auto generate event name when creating a group of events Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 22/23] selftests/ftrace: Add test case for GRP/ only input Steven Rostedt
2022-07-14 16:43 ` [for-next][PATCH 23/23] selftests/kprobe: Do not test for GRP/ without event failures Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714164331.609693610@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=quic_linyyuan@quicinc.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox