From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Mladek <pmladek@suse.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Marco Elver <elver@google.com>,
kasan-dev@googlegroups.com, Thomas Gleixner <tglx@linutronix.de>,
Johannes Berg <johannes.berg@intel.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Functional Testing <lkft@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Make console tracepoint safe in NMI() context
Date: Fri, 15 Jul 2022 11:02:48 -0400 [thread overview]
Message-ID: <20220715110248.02b294b7@gandalf.local.home> (raw)
In-Reply-To: <20220715120152.17760-1-pmladek@suse.com>
On Fri, 15 Jul 2022 14:01:52 +0200
Petr Mladek <pmladek@suse.com> wrote:
> + /*
> + * trace_console_rcuidle() is not working in NMI. printk()
> + * is used more often in NMI than in rcuidle context.
> + * Choose the less evil solution here.
> + *
> + * raw_smp_processor_id() is reliable in rcuidle context.
> + */
> + TP_CONDITION(!rcu_is_idle_cpu(raw_smp_processor_id())),
> +
As Marco mentioned in the other thread, would a check for
'rcu_is_watching()' be better?
-- Steve
> TP_STRUCT__entry(
> __dynamic_array(char, msg, len + 1)
> ),
prev parent reply other threads:[~2022-07-15 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 12:01 [PATCH] printk: Make console tracepoint safe in NMI() context Petr Mladek
2022-07-15 12:39 ` Marco Elver
2022-07-15 13:51 ` Steven Rostedt
2022-07-15 15:10 ` Paul E. McKenney
2022-07-15 15:25 ` Steven Rostedt
2022-07-15 15:34 ` Petr Mladek
2022-07-15 15:02 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715110248.02b294b7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=johannes.berg@intel.com \
--cc=john.ogness@linutronix.de \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox