From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE81DC433EF for ; Fri, 15 Jul 2022 18:12:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbiGOSMf (ORCPT ); Fri, 15 Jul 2022 14:12:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbiGOSMa (ORCPT ); Fri, 15 Jul 2022 14:12:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A91D59245; Fri, 15 Jul 2022 11:12:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB4D362315; Fri, 15 Jul 2022 18:12:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24257C3411E; Fri, 15 Jul 2022 18:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657908749; bh=zv88e6V2bOYszh5xZ5YFkXFxU2Be44JHufVZU7uo7YY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lOXj38MUE4WmuKeKIPlNexwIs7d8j8Mz4uoK2G7zN/dZp+RTkb2v8L75BR+FVb2zH NmLEm83eUNRwIqIcI9wL5Q7Y/K5KaSXYAggo90eNZJreO3MwD6YLDAVtSqrhawd220 FfTrGX7RzR5bYdQfxpxddrFbFuFVbOAP84mKTE5tFRcQ9vpdfUvihzKC280u33p+nf sgh91eVFS1/df/x4i5S5Y3xGZfhkxUDSNLG//qoPSaN62QmkmLK3zEnf05TyCfYrGC o42ruHmQt/OmwMwUVYrktc9irgZcBlYavqVg1mrCYYtvemdz22qgg797b5wCsDY7Xe fosRk69rVR62A== From: SeongJae Park To: SeongJae Park Cc: roger.pau@citrix.com, axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 0/2] Fix persistent grants negotiation with a behavior change Date: Fri, 15 Jul 2022 18:12:26 +0000 Message-Id: <20220715181226.126714-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715175521.126649-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On Fri, 15 Jul 2022 17:55:19 +0000 SeongJae Park wrote: > The first patch of this patchset fixes 'feature_persistent' parameter > handling in 'blkback' to respect the frontend's persistent grants > support always. The fix makes a behavioral change, so the second patch > makes the counterpart of 'blkfront' to consistently follow the behavior > change. I made the behavior change as requested by Andrii[1]. I therefore made similar behavior change to blkfront and Cc-ed stable for the second change, too. To make the change history clear and reduce the stable side overhead, however, it might be better to apply the v2, which don't make behavior change but only fix the issue, Cc stable@ for it, make the behavior change commits for both blkback and blkfront, update the documents, and don't Cc stable@ for the behavior change and documents update commits. One downside of that would be that it will make a behavioral difference in pre-5.19.x and post-5.19.x. I think both downsides are not critical, so posted this patchset in this shape. If anyone prefer some changes, please let me know, though. [1] https://lore.kernel.org/xen-devel/CAJwUmVB6H3iTs-C+U=v-pwJB7-_ZRHPxHzKRJZ22xEPW7z8a=g@mail.gmail.com/ Thanks, SJ > > Changes from v2 > (https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/) > - Keep the behavioral change of v1 > - Update blkfront's counterpart to follow the changed behavior > - Update documents for the changed behavior > > Changes from v1 > (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/) > - Avoid the behavioral change > (https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/) > - Rebase on latest xen/tip/linux-next > - Re-work by SeongJae Park > - Cc stable@ > > > > Maximilian Heyne (1): > xen, blkback: fix persistent grants negotiation > > SeongJae Park (1): > xen-blkfront: Apply 'feature_persistent' parameter when connect > > Documentation/ABI/testing/sysfs-driver-xen-blkback | 2 +- > Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- > drivers/block/xen-blkback/xenbus.c | 9 +++------ > drivers/block/xen-blkfront.c | 4 +--- > 4 files changed, 6 insertions(+), 11 deletions(-) > > -- > 2.25.1