From: Tzung-Bi Shih <tzungbi@kernel.org>
To: bleung@chromium.org, groeck@chromium.org
Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 01/10] platform/chrome: cros_kunit_util: add default value for `msg->result`
Date: Mon, 18 Jul 2022 05:09:05 +0000 [thread overview]
Message-ID: <20220718050914.2267370-2-tzungbi@kernel.org> (raw)
In-Reply-To: <20220718050914.2267370-1-tzungbi@kernel.org>
Add default value for `msg->result` so that it won't be garbage bytes
when the mock list is empty.
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
No v1. New in the series.
drivers/platform/chrome/cros_kunit_util.c | 7 ++++++-
drivers/platform/chrome/cros_kunit_util.h | 1 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_kunit_util.c b/drivers/platform/chrome/cros_kunit_util.c
index e031777dea87..6810d558d462 100644
--- a/drivers/platform/chrome/cros_kunit_util.c
+++ b/drivers/platform/chrome/cros_kunit_util.c
@@ -13,6 +13,8 @@
#include "cros_ec.h"
#include "cros_kunit_util.h"
+int cros_kunit_ec_xfer_mock_default_result;
+EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_result);
int cros_kunit_ec_xfer_mock_default_ret;
EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_ret);
@@ -24,8 +26,10 @@ int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_comman
struct ec_xfer_mock *mock;
mock = list_first_entry_or_null(&cros_kunit_ec_xfer_mock_in, struct ec_xfer_mock, list);
- if (!mock)
+ if (!mock) {
+ msg->result = cros_kunit_ec_xfer_mock_default_result;
return cros_kunit_ec_xfer_mock_default_ret;
+ }
list_del(&mock->list);
@@ -89,6 +93,7 @@ EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_next);
void cros_kunit_mock_reset(void)
{
+ cros_kunit_ec_xfer_mock_default_result = 0;
cros_kunit_ec_xfer_mock_default_ret = 0;
INIT_LIST_HEAD(&cros_kunit_ec_xfer_mock_in);
INIT_LIST_HEAD(&cros_kunit_ec_xfer_mock_out);
diff --git a/drivers/platform/chrome/cros_kunit_util.h b/drivers/platform/chrome/cros_kunit_util.h
index 79c4525f873c..79c4f259f2bb 100644
--- a/drivers/platform/chrome/cros_kunit_util.h
+++ b/drivers/platform/chrome/cros_kunit_util.h
@@ -23,6 +23,7 @@ struct ec_xfer_mock {
u32 o_data_len;
};
+extern int cros_kunit_ec_xfer_mock_default_result;
extern int cros_kunit_ec_xfer_mock_default_ret;
int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_command *msg);
--
2.37.0.170.g444d1eabd0-goog
next prev parent reply other threads:[~2022-07-18 5:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 5:09 [PATCH v2 00/10] platform/chrome: Kunit tests and refactor for cros_ec_cmd_xfer() Tzung-Bi Shih
2022-07-18 5:09 ` Tzung-Bi Shih [this message]
2022-07-18 13:35 ` [PATCH v2 01/10] platform/chrome: cros_kunit_util: add default value for `msg->result` Guenter Roeck
2022-07-19 4:00 ` Tzung-Bi Shih
2022-07-19 21:27 ` Guenter Roeck
2022-07-20 1:00 ` Tzung-Bi Shih
2022-07-18 5:09 ` [PATCH v2 02/10] platform/chrome: cros_ec_proto: add "cros_ec_" prefix to send_command() Tzung-Bi Shih
2022-07-18 5:09 ` [PATCH v2 03/10] platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_cmd_xfer() Tzung-Bi Shih
2022-07-18 5:09 ` [PATCH v2 04/10] platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_send_command() Tzung-Bi Shih
2022-07-18 5:09 ` [PATCH v2 05/10] platform/chrome: cros_ec_proto: separate cros_ec_xfer_command() Tzung-Bi Shih
2022-07-18 5:09 ` [PATCH v2 06/10] platform/chrome: cros_ec_proto: separate cros_ec_wait_until_complete() Tzung-Bi Shih
2022-07-18 13:32 ` Guenter Roeck
2022-07-18 5:09 ` [PATCH v2 07/10] platform/chrome: cros_ec_proto: change Kunit expectation when timed out Tzung-Bi Shih
2022-07-18 5:09 ` [PATCH v2 08/10] platform/chrome: cros_ec_proto: return -EAGAIN when retries " Tzung-Bi Shih
2022-07-18 13:33 ` Guenter Roeck
2022-07-18 5:09 ` [PATCH v2 09/10] platform/chrome: cros_ec_proto: add Kunit test for empty payload Tzung-Bi Shih
2022-07-18 13:36 ` Guenter Roeck
2022-07-18 5:09 ` [PATCH v2 10/10] platform/chrome: cros_ec_proto: return -EPROTO if " Tzung-Bi Shih
2022-07-20 1:30 ` [PATCH v2 00/10] platform/chrome: Kunit tests and refactor for cros_ec_cmd_xfer() patchwork-bot+chrome-platform
2022-07-21 8:50 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718050914.2267370-2-tzungbi@kernel.org \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox