* [PATCH] apparmor: Mark alloc_unconfined() as static
@ 2022-07-19 2:12 Souptick Joarder
2022-07-20 2:29 ` John Johansen
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2022-07-19 2:12 UTC (permalink / raw)
To: john.johansen, paul, jmorris, serge
Cc: apparmor, linux-security-module, linux-kernel,
Souptick Joarder (HPE), kernel test robot
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
Kernel test robot throws below warning ->
security/apparmor/policy_ns.c:83:20: warning: no previous prototype
for function 'alloc_unconfined' [-Wmissing-prototypes]
Mark it as static.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
---
security/apparmor/policy_ns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/apparmor/policy_ns.c b/security/apparmor/policy_ns.c
index 300953a02a24..4f6e9b3c24e6 100644
--- a/security/apparmor/policy_ns.c
+++ b/security/apparmor/policy_ns.c
@@ -80,7 +80,7 @@ const char *aa_ns_name(struct aa_ns *curr, struct aa_ns *view, bool subns)
return aa_hidden_ns_name;
}
-struct aa_profile *alloc_unconfined(const char *name)
+static struct aa_profile *alloc_unconfined(const char *name)
{
struct aa_profile *profile;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] apparmor: Mark alloc_unconfined() as static
2022-07-19 2:12 [PATCH] apparmor: Mark alloc_unconfined() as static Souptick Joarder
@ 2022-07-20 2:29 ` John Johansen
0 siblings, 0 replies; 2+ messages in thread
From: John Johansen @ 2022-07-20 2:29 UTC (permalink / raw)
To: Souptick Joarder, paul, jmorris, serge
Cc: apparmor, linux-security-module, linux-kernel, kernel test robot
On 7/18/22 19:12, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> Kernel test robot throws below warning ->
> security/apparmor/policy_ns.c:83:20: warning: no previous prototype
> for function 'alloc_unconfined' [-Wmissing-prototypes]
>
> Mark it as static.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
Thanks, I have pulled this into apparmor-next
Acked-by: John Johansen <john.johansen@canonical.com>
> ---
> security/apparmor/policy_ns.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/policy_ns.c b/security/apparmor/policy_ns.c
> index 300953a02a24..4f6e9b3c24e6 100644
> --- a/security/apparmor/policy_ns.c
> +++ b/security/apparmor/policy_ns.c
> @@ -80,7 +80,7 @@ const char *aa_ns_name(struct aa_ns *curr, struct aa_ns *view, bool subns)
> return aa_hidden_ns_name;
> }
>
> -struct aa_profile *alloc_unconfined(const char *name)
> +static struct aa_profile *alloc_unconfined(const char *name)
> {
> struct aa_profile *profile;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-20 2:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-19 2:12 [PATCH] apparmor: Mark alloc_unconfined() as static Souptick Joarder
2022-07-20 2:29 ` John Johansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox