public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tong Zhang <ztong0001@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Colin Ian King <colin.king@intel.com>,
	Saurav Girepunje <saurav.girepunje@gmail.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Johan Hovold <johan@kernel.org>,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	Zheyu Ma <zheyuma97@gmail.com>
Subject: Re: [PATCH v2 0/3] staging: rtl8192u: fix rmmod warn when wlan0 is renamed
Date: Tue, 19 Jul 2022 11:04:31 +0300	[thread overview]
Message-ID: <20220719080431.GY2316@kadam> (raw)
In-Reply-To: <20220719055047.322355-1-ztong0001@gmail.com>

On Mon, Jul 18, 2022 at 10:50:35PM -0700, Tong Zhang wrote:
> There are 4 debug files created under /proc/net/[Devname]. Devname could
> be wlan0 initially, however it could be renamed later to e.g. enx00e04c000002.
> This will cause problem during debug file teardown since it uses
> netdev->name which is no longer wlan0. To solve this problem, add a
> notifier to handle device renaming.
> 
> Also, due to this is purely for debuging as files are created read only,
> move this to debugfs like other NIC drivers do instead of using procfs.
> 
> Reported-by: Zheyu Ma <zheyuma97@gmail.com>
> Tested-by: Zheyu Ma <zheyuma97@gmail.com>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> 
> v2: break down patch and fix pointer check
> 
> Tong Zhang (3):
>   staging: rtl8192u: move debug stuff to its own file
>   staging: rtl8192u: move debug files to debugfs
>   staging: rtl8192u: fix rmmod warn when wlan0 is renamed

Thanks!  This is much better.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


  reply	other threads:[~2022-07-19  8:05 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-16 12:16 [BUG] staging: rtl8192u: Found a bug when removing the module Zheyu Ma
2022-07-17  7:01 ` Tong Zhang
2022-07-17  7:01 ` [PATCH] staging: rtl8192u: fix rmmod warn when wlan0 is renamed Tong Zhang
2022-07-17  8:04   ` Zheyu Ma
2022-07-18 11:39   ` Dan Carpenter
2022-07-18 11:47   ` Dan Carpenter
2022-07-18 12:01   ` Dan Carpenter
2022-07-19  5:50     ` [PATCH v2 0/3] " Tong Zhang
2022-07-19  8:04       ` Dan Carpenter [this message]
2022-07-19  5:50     ` [PATCH v2 1/3] staging: rtl8192u: move debug stuff to its own file Tong Zhang
2022-07-19  5:50     ` [PATCH v2 2/3] staging: rtl8192u: move debug files to debugfs Tong Zhang
2022-07-19 12:37       ` Greg Kroah-Hartman
2022-07-20  4:58         ` Tong Zhang
2022-07-27  6:35           ` Greg Kroah-Hartman
2022-07-20  6:30         ` Tong Zhang
2022-07-27  6:37           ` Greg Kroah-Hartman
2022-07-29  3:51             ` Tong Zhang
2022-07-29  3:52             ` [PATCH v3 0/3] staging: rtl8192u: fix rmmod warn when device is renamed Tong Zhang
2022-07-29  3:52               ` [PATCH v3 1/3] staging: rtl8192u: move debug stuff to its own file Tong Zhang
2022-07-29  6:23                 ` Philipp Hortmann
2022-07-30  3:35                   ` Tong Zhang
2022-07-29  3:52               ` [PATCH v3 2/3] staging: rtl8192u: move debug files to debugfs Tong Zhang
2022-07-29  7:31                 ` Greg Kroah-Hartman
2022-07-29  3:52               ` [PATCH v3 3/3] staging: rtl8192u: fix rmmod warn when device is renamed Tong Zhang
2022-07-29  7:27                 ` Greg Kroah-Hartman
2022-07-30  3:33                   ` Tong Zhang
2022-07-30  3:33                   ` [PATCH v4 0/4] " Tong Zhang
2022-07-30  3:33                   ` [PATCH v4 1/4] staging: rtl8192u: move debug stuff to its own file Tong Zhang
2022-07-30  3:33                   ` [PATCH v4 2/4] staging: rtl8192u: remove unnecessary cast Tong Zhang
2022-07-30  3:33                   ` [PATCH v4 3/4] staging: rtl8192u: move debug files to debugfs Tong Zhang
2022-07-30  3:33                   ` [PATCH v4 4/4] staging: rtl8192u: fix rmmod warn when device is renamed Tong Zhang
2022-07-19  5:50     ` [PATCH v2 3/3] staging: rtl8192u: fix rmmod warn when wlan0 " Tong Zhang
2022-07-19 12:39       ` Greg Kroah-Hartman
2022-07-20  6:16         ` Tong Zhang
2022-07-19  5:52     ` [PATCH] " Tong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220719080431.GY2316@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=colin.king@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=saurav.girepunje@gmail.com \
    --cc=zheyuma97@gmail.com \
    --cc=ztong0001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox