From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.10 039/112] ASoC: Intel: Skylake: Correct the ssp rate discovery in skl_get_ssp_clks()
Date: Tue, 19 Jul 2022 13:53:32 +0200 [thread overview]
Message-ID: <20220719114630.091756834@linuxfoundation.org> (raw)
In-Reply-To: <20220719114626.156073229@linuxfoundation.org>
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
[ Upstream commit 219af251bd1694bce1f627d238347d2eaf13de61 ]
The present flag is only set once when one rate has been found to be saved.
This will effectively going to ignore any rate discovered at later time and
based on the code, this is not the intention.
Fixes: bc2bd45b1f7f3 ("ASoC: Intel: Skylake: Parse nhlt and register clock device")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20220630065638.11183-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
sound/soc/intel/skylake/skl-nhlt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-nhlt.c b/sound/soc/intel/skylake/skl-nhlt.c
index 87c891c46291..c668e10baade 100644
--- a/sound/soc/intel/skylake/skl-nhlt.c
+++ b/sound/soc/intel/skylake/skl-nhlt.c
@@ -201,7 +201,6 @@ static void skl_get_ssp_clks(struct skl_dev *skl, struct skl_ssp_clk *ssp_clks,
struct nhlt_fmt_cfg *fmt_cfg;
struct wav_fmt_ext *wav_fmt;
unsigned long rate;
- bool present = false;
int rate_index = 0;
u16 channels, bps;
u8 clk_src;
@@ -215,6 +214,8 @@ static void skl_get_ssp_clks(struct skl_dev *skl, struct skl_ssp_clk *ssp_clks,
return;
for (i = 0; i < fmt->fmt_count; i++) {
+ bool present = false;
+
fmt_cfg = &fmt->fmt_config[i];
wav_fmt = &fmt_cfg->fmt_ext;
--
2.35.1
next prev parent reply other threads:[~2022-07-19 12:20 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 11:52 [PATCH 5.10 000/112] 5.10.132-rc1 review Greg Kroah-Hartman
2022-07-19 11:52 ` [PATCH 5.10 001/112] ALSA: hda - Add fixup for Dell Latitidue E5430 Greg Kroah-Hartman
2022-07-19 11:52 ` [PATCH 5.10 002/112] ALSA: hda/conexant: Apply quirk for another HP ProDesk 600 G3 model Greg Kroah-Hartman
2022-07-19 11:52 ` [PATCH 5.10 003/112] ALSA: hda/realtek: Fix headset mic for Acer SF313-51 Greg Kroah-Hartman
2022-07-19 11:52 ` [PATCH 5.10 004/112] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671 Greg Kroah-Hartman
2022-07-19 11:52 ` [PATCH 5.10 005/112] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc221 Greg Kroah-Hartman
2022-07-19 11:52 ` [PATCH 5.10 006/112] ALSA: hda/realtek - Enable the headset-mic on a Xiaomis laptop Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 007/112] xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 008/112] fix race between exit_itimers() and /proc/pid/timers Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 009/112] mm: split huge PUD on wp_huge_pud fallback Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 010/112] tracing/histograms: Fix memory leak problem Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 011/112] net: sock: tracing: Fix sock_exceed_buf_limit not to dereference stale pointer Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 012/112] ip: fix dflt addr selection for connected nexthop Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 013/112] ARM: 9213/1: Print message about disabled Spectre workarounds only once Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 014/112] ARM: 9214/1: alignment: advance IT state after emulating Thumb instruction Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 015/112] wifi: mac80211: fix queue selection for mesh/OCB interfaces Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 016/112] cgroup: Use separate src/dst nodes when preloading css_sets for migration Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 017/112] btrfs: return -EAGAIN for NOWAIT dio reads/writes on compressed and inline extents Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 018/112] drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault_addr() error Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 019/112] drm/panfrost: Fix shrinker list corruption by madvise IOCTL Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 020/112] fs/remap: constrain dedupe of EOF blocks Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 021/112] nilfs2: fix incorrect masking of permission flags for symlinks Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 022/112] sh: convert nommu io{re,un}map() to static inline functions Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 023/112] Revert "evm: Fix memleak in init_desc" Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 024/112] ext4: fix race condition between ext4_write and ext4_convert_inline_data Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 025/112] ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 026/112] spi: amd: Limit max transfer and message size Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 027/112] ARM: 9209/1: Spectre-BHB: avoid pr_info() every time a CPU comes out of idle Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 028/112] ARM: 9210/1: Mark the FDT_FIXED sections as shareable Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 029/112] net/mlx5e: kTLS, Fix build time constant test in TX Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 030/112] net/mlx5e: kTLS, Fix build time constant test in RX Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 031/112] net/mlx5e: Fix capability check for updating vnic env counters Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 032/112] drm/i915: fix a possible refcount leak in intel_dp_add_mst_connector() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 033/112] ima: Fix a potential integer overflow in ima_appraise_measurement Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 034/112] ASoC: sgtl5000: Fix noise on shutdown/remove Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 035/112] ASoC: tas2764: Add post reset delays Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 036/112] ASoC: tas2764: Fix and extend FSYNC polarity handling Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 037/112] ASoC: tas2764: Correct playback volume range Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 038/112] ASoC: tas2764: Fix amp gain register offset & default Greg Kroah-Hartman
2022-07-19 11:53 ` Greg Kroah-Hartman [this message]
2022-07-19 11:53 ` [PATCH 5.10 040/112] ASoC: Intel: Skylake: Correct the handling of fmt_config flexible array Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 041/112] net: stmmac: dwc-qos: Disable split header for Tegra194 Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 042/112] sysctl: Fix data races in proc_dointvec() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 043/112] sysctl: Fix data races in proc_douintvec() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 044/112] sysctl: Fix data races in proc_dointvec_minmax() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 045/112] sysctl: Fix data races in proc_douintvec_minmax() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 046/112] sysctl: Fix data races in proc_doulongvec_minmax() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 047/112] sysctl: Fix data races in proc_dointvec_jiffies() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 048/112] tcp: Fix a data-race around sysctl_tcp_max_orphans Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 049/112] inetpeer: Fix data-races around sysctl Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 050/112] net: Fix data-races around sysctl_mem Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 051/112] cipso: Fix data-races around sysctl Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 052/112] icmp: " Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 053/112] ipv4: Fix a data-race around sysctl_fib_sync_mem Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 054/112] ARM: dts: at91: sama5d2: Fix typo in i2s1 node Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 055/112] ARM: dts: sunxi: Fix SPI NOR campatible on Orange Pi Zero Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 056/112] drm/i915/selftests: fix a couple IS_ERR() vs NULL tests Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 057/112] drm/i915/gt: Serialize TLB invalidates with GT resets Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 058/112] sysctl: Fix data-races in proc_dointvec_ms_jiffies() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 059/112] icmp: Fix a data-race around sysctl_icmp_ratelimit Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 060/112] icmp: Fix a data-race around sysctl_icmp_ratemask Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 061/112] raw: Fix a data-race around sysctl_raw_l3mdev_accept Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 062/112] ipv4: Fix data-races around sysctl_ip_dynaddr Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 063/112] nexthop: Fix data-races around nexthop_compat_mode Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 064/112] net: ftgmac100: Hold reference returned by of_get_child_by_name() Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 065/112] ima: force signature verification when CONFIG_KEXEC_SIG is configured Greg Kroah-Hartman
2022-07-19 11:53 ` [PATCH 5.10 066/112] ima: Fix potential memory leak in ima_init_crypto() Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 067/112] sfc: fix use after free when disabling sriov Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 068/112] seg6: fix skb checksum evaluation in SRH encapsulation/insertion Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 069/112] seg6: fix skb checksum in SRv6 End.B6 and End.B6.Encaps behaviors Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 070/112] seg6: bpf: fix skb checksum in bpf_push_seg6_encap() Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 071/112] sfc: fix kernel panic when creating VF Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 072/112] net: atlantic: remove deep parameter on suspend/resume functions Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 073/112] net: atlantic: remove aq_nic_deinit() when resume Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 074/112] KVM: x86: Fully initialize struct kvm_lapic_irq in kvm_pv_kick_cpu_op() Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 075/112] net/tls: Check for errors in tls_device_init Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 076/112] mm: sysctl: fix missing numa_stat when !CONFIG_HUGETLB_PAGE Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 077/112] virtio_mmio: Add missing PM calls to freeze/restore Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 078/112] virtio_mmio: Restore guest page size on resume Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 079/112] netfilter: br_netfilter: do not skip all hooks with 0 priority Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 080/112] scsi: hisi_sas: Limit max hw sectors for v3 HW Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 081/112] cpufreq: pmac32-cpufreq: Fix refcount leak bug Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 082/112] platform/x86: hp-wmi: Ignore Sanitization Mode event Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 083/112] net: tipc: fix possible refcount leak in tipc_sk_create() Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 084/112] NFC: nxp-nci: dont print header length mismatch on i2c error Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 085/112] nvme-tcp: always fail a request when sending it failed Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 086/112] nvme: fix regression when disconnect a recovering ctrl Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 087/112] net: sfp: fix memory leak in sfp_probe() Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 088/112] ASoC: ops: Fix off by one in range control validation Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 089/112] pinctrl: aspeed: Fix potential NULL dereference in aspeed_pinmux_set_mux() Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 090/112] ASoC: SOF: Intel: hda-loader: Clarify the cl_dsp_init() flow Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 091/112] ASoC: wm5110: Fix DRE control Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 092/112] ASoC: dapm: Initialise kcontrol data for mux/demux controls Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 093/112] ASoC: cs47l15: Fix event generation for low power mux control Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 094/112] ASoC: madera: Fix event generation for OUT1 demux Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 095/112] ASoC: madera: Fix event generation for rate controls Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 096/112] irqchip: or1k-pic: Undefine mask_ack for level triggered hardware Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 097/112] x86: Clear .brk area at early boot Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 098/112] soc: ixp4xx/npe: Fix unused match warning Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 099/112] ARM: dts: stm32: use the correct clock source for CEC on stm32mp151 Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 100/112] Revert "can: xilinx_can: Limit CANFD brp to 2" Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 101/112] nvme-pci: phison e16 has bogus namespace ids Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 102/112] signal handling: dont use BUG_ON() for debugging Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 103/112] USB: serial: ftdi_sio: add Belimo device ids Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 104/112] usb: typec: add missing uevent when partner support PD Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 105/112] usb: dwc3: gadget: Fix event pending check Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 106/112] tty: serial: samsung_tty: set dma burst_size to 1 Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 107/112] vt: fix memory overlapping when deleting chars in the buffer Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 108/112] serial: 8250: fix return error code in serial8250_request_std_resource() Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 109/112] serial: stm32: Clear prev values before setting RTS delays Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 110/112] serial: pl011: UPSTAT_AUTORTS requires .throttle/unthrottle Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 111/112] serial: 8250: Fix PM usage_count for console handover Greg Kroah-Hartman
2022-07-19 11:54 ` [PATCH 5.10 112/112] x86/pat: Fix x86_has_pat_wp() Greg Kroah-Hartman
2022-07-19 18:35 ` [PATCH 5.10 000/112] 5.10.132-rc1 review Florian Fainelli
2022-07-20 1:00 ` Samuel Zou
2022-07-20 6:19 ` Guenter Roeck
2022-07-20 9:39 ` Naresh Kamboju
2022-07-20 14:49 ` Sudip Mukherjee (Codethink)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719114630.091756834@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox