From: Jakub Kicinski <kuba@kernel.org>
To: LemmyHuang <hlm3280@163.com>
Cc: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: fix condition for increasing pingpong count
Date: Tue, 19 Jul 2022 17:49:15 -0700 [thread overview]
Message-ID: <20220719174915.48f830b4@kernel.org> (raw)
In-Reply-To: <20220719130136.11907-1-hlm3280@163.com>
On Tue, 19 Jul 2022 21:01:37 +0800 LemmyHuang wrote:
> - if (before(tp->lsndtime, icsk->icsk_ack.lrcvtime) &&
> + if ((tp->lsndtime <= icsk->icsk_ack.lrcvtime) &&
Are you sure you don't need to take care of the values wrapping?
before() does that. You may want !after() if you want to allow equal.
next prev parent reply other threads:[~2022-07-20 0:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 13:01 [PATCH net-next] tcp: fix condition for increasing pingpong count LemmyHuang
2022-07-20 0:49 ` Jakub Kicinski [this message]
2022-07-20 6:47 ` LemmyHuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719174915.48f830b4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hlm3280@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox