From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] of: overlay: Move devicetree_corrupt() check up
Date: Tue, 19 Jul 2022 15:55:12 -0600 [thread overview]
Message-ID: <20220719215512.GA1882804-robh@kernel.org> (raw)
In-Reply-To: <c91ce7112eb5167ea46a43d8a980e76b920010ba.1657893306.git.geert+renesas@glider.be>
On Fri, 15 Jul 2022 16:03:14 +0200, Geert Uytterhoeven wrote:
> There is no point in doing several preparatory steps in
> of_overlay_fdt_apply(), only to see of_overlay_apply() return early
> because of a corrupt device tree.
>
> Move the check for a corrupt device tree from of_overlay_apply() to
> of_overlay_fdt_apply(), to check for this as early as possible.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/of/overlay.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2022-07-19 21:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 14:03 [PATCH 0/2] of: overlay: Miscellaneous improvements Geert Uytterhoeven
2022-07-15 14:03 ` [PATCH 1/2] of: overlay: Move devicetree_corrupt() check up Geert Uytterhoeven
2022-07-19 21:55 ` Rob Herring [this message]
2022-07-15 14:03 ` [PATCH 2/2] of: overlay: Simplify of_overlay_fdt_apply() tail Geert Uytterhoeven
2022-07-19 21:55 ` Rob Herring
2022-07-18 23:42 ` [PATCH 0/2] of: overlay: Miscellaneous improvements Frank Rowand
2022-07-19 18:37 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719215512.GA1882804-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox