From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@suse.de>, Sasha Levin <sashal@kernel.org>,
luto@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
pawan.kumar.gupta@linux.intel.com
Subject: [PATCH AUTOSEL 5.18 24/54] x86/speculation: Fix RSB filling with CONFIG_RETPOLINE=n
Date: Tue, 19 Jul 2022 21:10:01 -0400 [thread overview]
Message-ID: <20220720011031.1023305-24-sashal@kernel.org> (raw)
In-Reply-To: <20220720011031.1023305-1-sashal@kernel.org>
From: Josh Poimboeuf <jpoimboe@kernel.org>
[ Upstream commit b2620facef4889fefcbf2e87284f34dcd4189bce ]
If a kernel is built with CONFIG_RETPOLINE=n, but the user still wants
to mitigate Spectre v2 using IBRS or eIBRS, the RSB filling will be
silently disabled.
There's nothing retpoline-specific about RSB buffer filling. Remove the
CONFIG_RETPOLINE guards around it.
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/x86/entry/entry_32.S | 2 --
arch/x86/entry/entry_64.S | 2 --
arch/x86/include/asm/nospec-branch.h | 2 --
3 files changed, 6 deletions(-)
diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S
index 887420844066..e309e7156038 100644
--- a/arch/x86/entry/entry_32.S
+++ b/arch/x86/entry/entry_32.S
@@ -698,7 +698,6 @@ SYM_CODE_START(__switch_to_asm)
movl %ebx, PER_CPU_VAR(__stack_chk_guard)
#endif
-#ifdef CONFIG_RETPOLINE
/*
* When switching from a shallower to a deeper call stack
* the RSB may either underflow or use entries populated
@@ -707,7 +706,6 @@ SYM_CODE_START(__switch_to_asm)
* speculative execution to prevent attack.
*/
FILL_RETURN_BUFFER %ebx, RSB_CLEAR_LOOPS, X86_FEATURE_RSB_CTXSW
-#endif
/* Restore flags or the incoming task to restore AC state. */
popfl
diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index d8376e5fe1af..024367c81b7e 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -245,7 +245,6 @@ SYM_FUNC_START(__switch_to_asm)
movq %rbx, PER_CPU_VAR(fixed_percpu_data) + stack_canary_offset
#endif
-#ifdef CONFIG_RETPOLINE
/*
* When switching from a shallower to a deeper call stack
* the RSB may either underflow or use entries populated
@@ -254,7 +253,6 @@ SYM_FUNC_START(__switch_to_asm)
* speculative execution to prevent attack.
*/
FILL_RETURN_BUFFER %r12, RSB_CLEAR_LOOPS, X86_FEATURE_RSB_CTXSW
-#endif
/* restore callee-saved registers */
popq %r15
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index a790109f9337..257d24a67a81 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -111,11 +111,9 @@
* monstrosity above, manually.
*/
.macro FILL_RETURN_BUFFER reg:req nr:req ftr:req
-#ifdef CONFIG_RETPOLINE
ALTERNATIVE "jmp .Lskip_rsb_\@", "", \ftr
__FILL_RETURN_BUFFER(\reg,\nr,%_ASM_SP)
.Lskip_rsb_\@:
-#endif
.endm
#else /* __ASSEMBLY__ */
--
2.35.1
next prev parent reply other threads:[~2022-07-20 1:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 1:09 [PATCH AUTOSEL 5.18 01/54] Revert "evm: Fix memleak in init_desc" Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 02/54] ARM: rockchip: Add missing of_node_put() in rockchip_suspend_init() Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 03/54] x86/kvm/vmx: Make noinstr clean Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 04/54] x86/cpufeatures: Move RETPOLINE flags to word 11 Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 05/54] x86/retpoline: Cleanup some #ifdefery Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 06/54] x86/retpoline: Swizzle retpoline thunk Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 07/54] x86/retpoline: Use -mfunction-return Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 08/54] x86,objtool: Create .return_sites Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 09/54] x86/kvm: Fix SETcc emulation for return thunks Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 10/54] x86/vsyscall_emu/64: Don't use RET in vsyscall emulation Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 11/54] x86/sev: Avoid using __x86_return_thunk Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 12/54] objtool: Treat .text.__x86.* as noinstr Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 13/54] x86/bugs: Report AMD retbleed vulnerability Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 14/54] x86/bugs: Add AMD retbleed= boot parameter Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 15/54] x86/bugs: Enable STIBP for JMP2RET Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 16/54] x86/bugs: Keep a per-CPU IA32_SPEC_CTRL value Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 17/54] x86/bugs: Optimize SPEC_CTRL MSR writes Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 18/54] x86/bugs: Split spectre_v2_select_mitigation() and spectre_v2_user_select_mitigation() Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 19/54] x86/bugs: Report Intel retbleed vulnerability Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 20/54] objtool: Update Retpoline validation Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 21/54] x86/xen: Rename SYS* entry points Sasha Levin
2022-07-20 1:09 ` [PATCH AUTOSEL 5.18 22/54] x86/bugs: Do IBPB fallback check only once Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 23/54] x86/cpu/amd: Add Spectral Chicken Sasha Levin
2022-07-20 1:10 ` Sasha Levin [this message]
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 25/54] KVM: VMX: Flatten __vmx_vcpu_run() Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 26/54] KVM: VMX: Convert launched argument to flags Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 27/54] KVM: VMX: Prevent guest RSB poisoning attacks with eIBRS Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 28/54] tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver Sasha Levin
2022-07-25 5:35 ` Jiri Slaby
2022-07-25 7:00 ` Greg Kroah-Hartman
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 29/54] wifi: mac80211: check skb_shared in ieee80211_8023_xmit() Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 30/54] wifi: mac80211: do not wake queues on a vif that is being stopped Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 31/54] wifi: cfg80211: Allow P2P client interface to indicate port authorization Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 32/54] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830 Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 33/54] nilfs2: fix incorrect masking of permission flags for symlinks Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 34/54] xdp: Fix spurious packet loss in generic XDP TX path Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 35/54] drm/ssd130x: Fix pre-charge period setting Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 36/54] ASoC: ti: omap-mcbsp: duplicate sysfs error Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 37/54] ASoC: tlv320adcx140: Fix tx_mask check Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 38/54] ASoC: wcd9335: Use int array instead of bitmask for TX mixers Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 39/54] ASoC: wm5102: Fix event generation for output compensation Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 40/54] ASoC: wm8998: Fix event generation for input mux Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 41/54] ASoC: cs47l92: Fix event generation for OUT1 demux Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 42/54] ASoC: arizona: Update arizona_aif_cfg_changed to use RX_BCLK_RATE Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 43/54] ASoC: qdsp6: fix potential memory leak in q6apm_get_audioreach_graph() Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 44/54] ASoC: rt5640: Fix the wrong state of JD1 and JD2 Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 45/54] scsi: target: Fix WRITE_SAME No Data Buffer crash Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 46/54] x86/kexec: Disable RET on kexec Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 47/54] platform/x86: gigabyte-wmi: add support for B660I AORUS PRO DDR4 Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 48/54] platform/x86: asus-wmi: Add key mappings Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 49/54] platform/x86: intel_atomisp2_led: Also turn off the always-on camera LED on the Asus T100TAF Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 50/54] scsi: ufs: core: Fix missing clk change notification on host reset Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 51/54] scsi: pm80xx: Fix 'Unknown' max/min linkrate Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 52/54] scsi: pm80xx: Set stopped phy's linkrate to Disabled Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 53/54] KVM: nVMX: Always enable TSC scaling for L2 when it was enabled for L1 Sasha Levin
2022-07-20 1:10 ` [PATCH AUTOSEL 5.18 54/54] ubsan: disable UBSAN_DIV_ZERO for clang Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720011031.1023305-24-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox