public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Oder Chiou <oder_chiou@realtek.com>,
	Sameer Pujar <spujar@nvidia.com>, Mark Brown <broonie@kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	alsa-devel@alsa-project.org
Subject: [PATCH AUTOSEL 5.18 44/54] ASoC: rt5640: Fix the wrong state of JD1 and JD2
Date: Tue, 19 Jul 2022 21:10:21 -0400	[thread overview]
Message-ID: <20220720011031.1023305-44-sashal@kernel.org> (raw)
In-Reply-To: <20220720011031.1023305-1-sashal@kernel.org>

From: Oder Chiou <oder_chiou@realtek.com>

[ Upstream commit 051dade346957d5b68ad986f497835805fa7a9dd ]

The patch fixes the wrong state of JD1 and JD2 while the bst1 or bst2 is
power on in the HDA JD using.

Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
Reported-by: Sameer Pujar <spujar@nvidia.com>
Link: https://lore.kernel.org/r/20220705101134.16792-1-oder_chiou@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 sound/soc/codecs/rt5640.c | 30 ++++++++++++++++++++++--------
 1 file changed, 22 insertions(+), 8 deletions(-)

diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
index 3559d9ecfa07..188c8f401a47 100644
--- a/sound/soc/codecs/rt5640.c
+++ b/sound/soc/codecs/rt5640.c
@@ -1984,7 +1984,12 @@ static int rt5640_set_bias_level(struct snd_soc_component *component,
 		snd_soc_component_write(component, RT5640_PWR_DIG2, 0x0000);
 		snd_soc_component_write(component, RT5640_PWR_VOL, 0x0000);
 		snd_soc_component_write(component, RT5640_PWR_MIXER, 0x0000);
-		snd_soc_component_write(component, RT5640_PWR_ANLG1, 0x0000);
+		if (rt5640->jd_src == RT5640_JD_SRC_HDA_HEADER)
+			snd_soc_component_write(component, RT5640_PWR_ANLG1,
+				0x0018);
+		else
+			snd_soc_component_write(component, RT5640_PWR_ANLG1,
+				0x0000);
 		snd_soc_component_write(component, RT5640_PWR_ANLG2, 0x0000);
 		break;
 
@@ -2393,9 +2398,15 @@ static void rt5640_jack_work(struct work_struct *work)
 static irqreturn_t rt5640_irq(int irq, void *data)
 {
 	struct rt5640_priv *rt5640 = data;
+	int delay = 0;
+
+	if (rt5640->jd_src == RT5640_JD_SRC_HDA_HEADER) {
+		cancel_delayed_work_sync(&rt5640->jack_work);
+		delay = 100;
+	}
 
 	if (rt5640->jack)
-		queue_delayed_work(system_long_wq, &rt5640->jack_work, 0);
+		queue_delayed_work(system_long_wq, &rt5640->jack_work, delay);
 
 	return IRQ_HANDLED;
 }
@@ -2580,6 +2591,12 @@ static void rt5640_enable_hda_jack_detect(
 
 	snd_soc_component_update_bits(component, RT5640_DUMMY1, 0x400, 0x0);
 
+	snd_soc_component_update_bits(component, RT5640_PWR_ANLG1,
+		RT5640_PWR_VREF2, RT5640_PWR_VREF2);
+	usleep_range(10000, 15000);
+	snd_soc_component_update_bits(component, RT5640_PWR_ANLG1,
+		RT5640_PWR_FV2, RT5640_PWR_FV2);
+
 	rt5640->jack = jack;
 
 	ret = request_irq(rt5640->irq, rt5640_irq,
@@ -2696,16 +2713,13 @@ static int rt5640_probe(struct snd_soc_component *component)
 
 	if (device_property_read_u32(component->dev,
 				     "realtek,jack-detect-source", &val) == 0) {
-		if (val <= RT5640_JD_SRC_GPIO4) {
+		if (val <= RT5640_JD_SRC_GPIO4)
 			rt5640->jd_src = val << RT5640_JD_SFT;
-		} else if (val == RT5640_JD_SRC_HDA_HEADER) {
+		else if (val == RT5640_JD_SRC_HDA_HEADER)
 			rt5640->jd_src = RT5640_JD_SRC_HDA_HEADER;
-			snd_soc_component_update_bits(component, RT5640_DUMMY1,
-				0x0300, 0x0);
-		} else {
+		else
 			dev_warn(component->dev, "Warning: Invalid jack-detect-source value: %d, leaving jack-detect disabled\n",
 				 val);
-		}
 	}
 
 	if (!device_property_read_bool(component->dev, "realtek,jack-detect-not-inverted"))
-- 
2.35.1


  parent reply	other threads:[~2022-07-20  1:15 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20  1:09 [PATCH AUTOSEL 5.18 01/54] Revert "evm: Fix memleak in init_desc" Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 02/54] ARM: rockchip: Add missing of_node_put() in rockchip_suspend_init() Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 03/54] x86/kvm/vmx: Make noinstr clean Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 04/54] x86/cpufeatures: Move RETPOLINE flags to word 11 Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 05/54] x86/retpoline: Cleanup some #ifdefery Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 06/54] x86/retpoline: Swizzle retpoline thunk Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 07/54] x86/retpoline: Use -mfunction-return Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 08/54] x86,objtool: Create .return_sites Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 09/54] x86/kvm: Fix SETcc emulation for return thunks Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 10/54] x86/vsyscall_emu/64: Don't use RET in vsyscall emulation Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 11/54] x86/sev: Avoid using __x86_return_thunk Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 12/54] objtool: Treat .text.__x86.* as noinstr Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 13/54] x86/bugs: Report AMD retbleed vulnerability Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 14/54] x86/bugs: Add AMD retbleed= boot parameter Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 15/54] x86/bugs: Enable STIBP for JMP2RET Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 16/54] x86/bugs: Keep a per-CPU IA32_SPEC_CTRL value Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 17/54] x86/bugs: Optimize SPEC_CTRL MSR writes Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 18/54] x86/bugs: Split spectre_v2_select_mitigation() and spectre_v2_user_select_mitigation() Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 19/54] x86/bugs: Report Intel retbleed vulnerability Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 20/54] objtool: Update Retpoline validation Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 21/54] x86/xen: Rename SYS* entry points Sasha Levin
2022-07-20  1:09 ` [PATCH AUTOSEL 5.18 22/54] x86/bugs: Do IBPB fallback check only once Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 23/54] x86/cpu/amd: Add Spectral Chicken Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 24/54] x86/speculation: Fix RSB filling with CONFIG_RETPOLINE=n Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 25/54] KVM: VMX: Flatten __vmx_vcpu_run() Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 26/54] KVM: VMX: Convert launched argument to flags Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 27/54] KVM: VMX: Prevent guest RSB poisoning attacks with eIBRS Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 28/54] tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver Sasha Levin
2022-07-25  5:35   ` Jiri Slaby
2022-07-25  7:00     ` Greg Kroah-Hartman
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 29/54] wifi: mac80211: check skb_shared in ieee80211_8023_xmit() Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 30/54] wifi: mac80211: do not wake queues on a vif that is being stopped Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 31/54] wifi: cfg80211: Allow P2P client interface to indicate port authorization Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 32/54] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830 Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 33/54] nilfs2: fix incorrect masking of permission flags for symlinks Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 34/54] xdp: Fix spurious packet loss in generic XDP TX path Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 35/54] drm/ssd130x: Fix pre-charge period setting Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 36/54] ASoC: ti: omap-mcbsp: duplicate sysfs error Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 37/54] ASoC: tlv320adcx140: Fix tx_mask check Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 38/54] ASoC: wcd9335: Use int array instead of bitmask for TX mixers Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 39/54] ASoC: wm5102: Fix event generation for output compensation Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 40/54] ASoC: wm8998: Fix event generation for input mux Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 41/54] ASoC: cs47l92: Fix event generation for OUT1 demux Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 42/54] ASoC: arizona: Update arizona_aif_cfg_changed to use RX_BCLK_RATE Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 43/54] ASoC: qdsp6: fix potential memory leak in q6apm_get_audioreach_graph() Sasha Levin
2022-07-20  1:10 ` Sasha Levin [this message]
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 45/54] scsi: target: Fix WRITE_SAME No Data Buffer crash Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 46/54] x86/kexec: Disable RET on kexec Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 47/54] platform/x86: gigabyte-wmi: add support for B660I AORUS PRO DDR4 Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 48/54] platform/x86: asus-wmi: Add key mappings Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 49/54] platform/x86: intel_atomisp2_led: Also turn off the always-on camera LED on the Asus T100TAF Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 50/54] scsi: ufs: core: Fix missing clk change notification on host reset Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 51/54] scsi: pm80xx: Fix 'Unknown' max/min linkrate Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 52/54] scsi: pm80xx: Set stopped phy's linkrate to Disabled Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 53/54] KVM: nVMX: Always enable TSC scaling for L2 when it was enabled for L1 Sasha Levin
2022-07-20  1:10 ` [PATCH AUTOSEL 5.18 54/54] ubsan: disable UBSAN_DIV_ZERO for clang Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720011031.1023305-44-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=spujar@nvidia.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox