[PATCH nolibc v1] selftests/nolibc: Avoid generated files being committed

[PATCH nolibc v1] selftests/nolibc: Avoid generated files being committed

[Willy Tarreau]

From: "Fernanda Ma'rouf" <fernandafmr12@gnuweeb.org>

After running the nolibc tests, the "git status" is not clean because
the generated files are not ignored. Create a `.gitignore` inside the
selftests/nolibc directory to ignore them.

Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Fernanda Ma'rouf <fernandafmr2@gmail.com>
Signed-off-by: Fernanda Ma'rouf <fernandafmr12@gnuweeb.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
---

Paul,

Fernanda sent me this which I think is a desirable cleanup to the
series I sent you. If you're fine with adding it on top of what you
already have, that's great. Otherwise I can queue it here for next
time, but this should improve the user's experience.

Thanks,
Willy

--
 tools/testing/selftests/nolibc/.gitignore | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 tools/testing/selftests/nolibc/.gitignore

diff --git a/tools/testing/selftests/nolibc/.gitignore b/tools/testing/selftests/nolibc/.gitignore
new file mode 100644
index 000000000000..4696df589d68
--- /dev/null
+++ b/tools/testing/selftests/nolibc/.gitignore
@@ -0,0 +1,4 @@
+/initramfs/
+/nolibc-test
+/run.out
+/sysroot/

base-commit: 1e93ece89dd1c6217b92ef6fc100df9ba202c30c

Re: [PATCH nolibc v1] selftests/nolibc: Avoid generated files being committed

[Paul E. McKenney]

On Wed, Jul 20, 2022 at 05:37:45AM +0200, Willy Tarreau wrote:
> From: "Fernanda Ma'rouf" <fernandafmr12@gnuweeb.org>
> 
> After running the nolibc tests, the "git status" is not clean because
> the generated files are not ignored. Create a `.gitignore` inside the
> selftests/nolibc directory to ignore them.
> 
> Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> Cc: Fernanda Ma'rouf <fernandafmr2@gmail.com>
> Signed-off-by: Fernanda Ma'rouf <fernandafmr12@gnuweeb.org>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
> ---
> 
> Paul,
> 
> Fernanda sent me this which I think is a desirable cleanup to the
> series I sent you. If you're fine with adding it on top of what you
> already have, that's great. Otherwise I can queue it here for next
> time, but this should improve the user's experience.

I queued it on top of the others.  ;-)

							Thanx, Paul

> Thanks,
> Willy
> 
> --
>  tools/testing/selftests/nolibc/.gitignore | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 tools/testing/selftests/nolibc/.gitignore
> 
> diff --git a/tools/testing/selftests/nolibc/.gitignore b/tools/testing/selftests/nolibc/.gitignore
> new file mode 100644
> index 000000000000..4696df589d68
> --- /dev/null
> +++ b/tools/testing/selftests/nolibc/.gitignore
> @@ -0,0 +1,4 @@
> +/initramfs/
> +/nolibc-test
> +/run.out
> +/sysroot/
> 
> base-commit: 1e93ece89dd1c6217b92ef6fc100df9ba202c30c

Re: [PATCH nolibc v1] selftests/nolibc: Avoid generated files being committed

[Willy Tarreau]

On Tue, Jul 19, 2022 at 08:59:40PM -0700, Paul E. McKenney wrote:
> On Wed, Jul 20, 2022 at 05:37:45AM +0200, Willy Tarreau wrote:
> > From: "Fernanda Ma'rouf" <fernandafmr12@gnuweeb.org>
> > 
> > After running the nolibc tests, the "git status" is not clean because
> > the generated files are not ignored. Create a `.gitignore` inside the
> > selftests/nolibc directory to ignore them.
> > 
> > Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> > Cc: Fernanda Ma'rouf <fernandafmr2@gmail.com>
> > Signed-off-by: Fernanda Ma'rouf <fernandafmr12@gnuweeb.org>
> > Signed-off-by: Willy Tarreau <w@1wt.eu>
> > ---
> > 
> > Paul,
> > 
> > Fernanda sent me this which I think is a desirable cleanup to the
> > series I sent you. If you're fine with adding it on top of what you
> > already have, that's great. Otherwise I can queue it here for next
> > time, but this should improve the user's experience.
> 
> I queued it on top of the others.  ;-)

Thank you!
Willy

[PATCH nolibc v1] selftests/nolibc: Avoid generated files being committed

[Fernanda Ma'rouf]

After running the nolibc tests, the "git status" is not clean because
the generated files are not ignored. Create a `.gitignore` inside the
selftests/nolibc directory to ignore them.

Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Fernanda Ma'rouf <fernandafmr2@gmail.com>
Signed-off-by: Fernanda Ma'rouf <fernandafmr12@gnuweeb.org>
---
 tools/testing/selftests/nolibc/.gitignore | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 tools/testing/selftests/nolibc/.gitignore

diff --git a/tools/testing/selftests/nolibc/.gitignore b/tools/testing/selftests/nolibc/.gitignore
new file mode 100644
index 000000000000..4696df589d68
--- /dev/null
+++ b/tools/testing/selftests/nolibc/.gitignore
@@ -0,0 +1,4 @@
+/initramfs/
+/nolibc-test
+/run.out
+/sysroot/

base-commit: 1e93ece89dd1c6217b92ef6fc100df9ba202c30c
-- 
Fernanda Ma'rouf

Re: [PATCH nolibc v1] selftests/nolibc: Avoid generated files being committed

[Willy Tarreau]

Hi Fernanda,

On Tue, Jul 19, 2022 at 05:56:25PM +0700, Fernanda Ma'rouf wrote:
> After running the nolibc tests, the "git status" is not clean because
> the generated files are not ignored. Create a `.gitignore` inside the
> selftests/nolibc directory to ignore them.

Ah thank you, I didn't know that .gitignore was per-directory, I though
it was only at the top. Yes that's a nice improvement, I'll forward it
to Paul as it's reasonable and not too late I think.

Thanks,
Willy