From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB99C43334 for ; Thu, 21 Jul 2022 14:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232083AbiGUO3J (ORCPT ); Thu, 21 Jul 2022 10:29:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231979AbiGUO3D (ORCPT ); Thu, 21 Jul 2022 10:29:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 72AFC83217 for ; Thu, 21 Jul 2022 07:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658413741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yWvXjU22B2a+CJZc9xqXnahaTSnreVnQQz8zOTHm+5E=; b=PJCar2Y9HxzR2RAjKF0u8Be45fWmHtB9+xnUi9O2fO4x59juWRz2mkn2xUlG53i7/N3ssz vg0q0kKm6utRp3cy8cjzP4AiXKh97PwUsCziCfWGedt/I3+WVgSokQbD6R6NgYBvTslsQL 3dhXHCCI7ESiqClEBvWun46snD9SzpE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-XKyvDQyxPI6ajXSFfY1Y2A-1; Thu, 21 Jul 2022 10:28:54 -0400 X-MC-Unique: XKyvDQyxPI6ajXSFfY1Y2A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3CC6811E80; Thu, 21 Jul 2022 14:28:53 +0000 (UTC) Received: from pauld.bos.com (dhcp-17-237.bos.redhat.com [10.18.17.237]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB53B40CF916; Thu, 21 Jul 2022 14:28:53 +0000 (UTC) From: Phil Auld To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Peter Zijlstra , Valentin Schneider , Steven Price Subject: [PATCH v4 0/2] cpuhp: fix some st->target issues Date: Thu, 21 Jul 2022 10:28:50 -0400 Message-Id: <20220721142852.2712895-1-pauld@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a couple of cpuhp inconsistencies. The first prevents target_store() from calling cpu_down() when target == state which prevents the cpu being incorrectly marked as dying. The second just makes the boot cpu have a valid cpuhp target rather than 0 (CPU_OFFLINE) while being in state CPU_ONLINE. A further issue which these two patches don't address is that the cpuX/online file looks at the device->offline state and can thus get out of sync with the actual cpuhp state if the cpuhp target is used to change state. v3: Added code to make sure st->target == target in the nop case. v4: Use WARN_ON in the case where state == target but st->target does not. Phil Auld (2): cpuhp: make target_store() a nop when target == state cpuhp: Set cpuhp target for boot cpu kernel/cpu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.31.1