public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Marangi <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jens Axboe <axboe@kernel.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [net-next PATCH v3 14/14] net: dsa: qca8k: move read_switch_id function to common code
Date: Sat, 23 Jul 2022 16:18:45 +0200	[thread overview]
Message-ID: <20220723141845.10570-15-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20220723141845.10570-1-ansuelsmth@gmail.com>

The same function to read the switch id is used by drivers based on
qca8k family switch. Move them to common code to make them accessible
also by other drivers.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 drivers/net/dsa/qca/qca8k-8xxx.c   | 30 -----------------------------
 drivers/net/dsa/qca/qca8k-common.c | 31 ++++++++++++++++++++++++++++++
 drivers/net/dsa/qca/qca8k.h        |  1 +
 3 files changed, 32 insertions(+), 30 deletions(-)

diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
index 34d0c4cea68d..9fed3b638739 100644
--- a/drivers/net/dsa/qca/qca8k-8xxx.c
+++ b/drivers/net/dsa/qca/qca8k-8xxx.c
@@ -1877,36 +1877,6 @@ static const struct dsa_switch_ops qca8k_switch_ops = {
 	.connect_tag_protocol	= qca8k_connect_tag_protocol,
 };
 
-static int qca8k_read_switch_id(struct qca8k_priv *priv)
-{
-	const struct qca8k_match_data *data;
-	u32 val;
-	u8 id;
-	int ret;
-
-	/* get the switches ID from the compatible */
-	data = of_device_get_match_data(priv->dev);
-	if (!data)
-		return -ENODEV;
-
-	ret = qca8k_read(priv, QCA8K_REG_MASK_CTRL, &val);
-	if (ret < 0)
-		return -ENODEV;
-
-	id = QCA8K_MASK_CTRL_DEVICE_ID(val);
-	if (id != data->id) {
-		dev_err(priv->dev, "Switch id detected %x but expected %x", id, data->id);
-		return -ENODEV;
-	}
-
-	priv->switch_id = id;
-
-	/* Save revision to communicate to the internal PHY driver */
-	priv->switch_revision = QCA8K_MASK_CTRL_REV_ID(val);
-
-	return 0;
-}
-
 static int
 qca8k_sw_probe(struct mdio_device *mdiodev)
 {
diff --git a/drivers/net/dsa/qca/qca8k-common.c b/drivers/net/dsa/qca/qca8k-common.c
index 02559990a097..c33e9e11c322 100644
--- a/drivers/net/dsa/qca/qca8k-common.c
+++ b/drivers/net/dsa/qca/qca8k-common.c
@@ -8,6 +8,7 @@
 
 #include <linux/netdevice.h>
 #include <net/dsa.h>
+#include <linux/of_platform.h>
 #include <linux/if_bridge.h>
 
 #include "qca8k.h"
@@ -1207,3 +1208,33 @@ qca8k_port_lag_leave(struct dsa_switch *ds, int port,
 {
 	return qca8k_lag_refresh_portmap(ds, port, lag, true);
 }
+
+int qca8k_read_switch_id(struct qca8k_priv *priv)
+{
+	const struct qca8k_match_data *data;
+	u32 val;
+	u8 id;
+	int ret;
+
+	/* get the switches ID from the compatible */
+	data = of_device_get_match_data(priv->dev);
+	if (!data)
+		return -ENODEV;
+
+	ret = qca8k_read(priv, QCA8K_REG_MASK_CTRL, &val);
+	if (ret < 0)
+		return -ENODEV;
+
+	id = QCA8K_MASK_CTRL_DEVICE_ID(val);
+	if (id != data->id) {
+		dev_err(priv->dev, "Switch id detected %x but expected %x", id, data->id);
+		return -ENODEV;
+	}
+
+	priv->switch_id = id;
+
+	/* Save revision to communicate to the internal PHY driver */
+	priv->switch_revision = QCA8K_MASK_CTRL_REV_ID(val);
+
+	return 0;
+}
diff --git a/drivers/net/dsa/qca/qca8k.h b/drivers/net/dsa/qca/qca8k.h
index e6cf1ad68a9f..efbd3438aba8 100644
--- a/drivers/net/dsa/qca/qca8k.h
+++ b/drivers/net/dsa/qca/qca8k.h
@@ -432,6 +432,7 @@ extern const struct qca8k_mib_desc ar8327_mib[];
 extern const struct regmap_access_table qca8k_readable_table;
 int qca8k_mib_init(struct qca8k_priv *priv);
 void qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable);
+int qca8k_read_switch_id(struct qca8k_priv *priv);
 
 /* Common read/write/rmw function */
 int qca8k_read(struct qca8k_priv *priv, u32 reg, u32 *val);
-- 
2.36.1


      parent reply	other threads:[~2022-07-23 14:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23 14:18 [net-next PATCH v3 00/14] net: dsa: qca8k: code split for qca8k Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 01/14] net: dsa: qca8k: cache match data to speed up access Christian Marangi
2022-07-24 22:30   ` Vladimir Oltean
2022-07-24 20:27     ` Christian Marangi
2022-07-24 23:06       ` Vladimir Oltean
2022-07-24 20:42         ` Christian Marangi
2022-07-24 23:18           ` Vladimir Oltean
2022-07-24 20:49             ` Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 02/14] net: dsa: qca8k: make mib autocast feature optional Christian Marangi
2022-07-24 22:33   ` Vladimir Oltean
2022-07-24 20:29     ` Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 03/14] net: dsa: qca8k: move mib struct to common code Christian Marangi
2022-07-23 23:52   ` kernel test robot
2022-07-23 14:18 ` [net-next PATCH v3 04/14] net: dsa: qca8k: move qca8k read/write/rmw and reg table " Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 05/14] net: dsa: qca8k: move qca8k bulk read/write helper " Christian Marangi
2022-07-26  0:11   ` Vladimir Oltean
2022-07-23 14:18 ` [net-next PATCH v3 06/14] net: dsa: qca8k: move mib init function " Christian Marangi
2022-07-26  0:13   ` Vladimir Oltean
2022-07-23 14:18 ` [net-next PATCH v3 07/14] net: dsa: qca8k: move port set status/eee/ethtool stats " Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 08/14] net: dsa: qca8k: move bridge functions " Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 09/14] net: dsa: qca8k: move set age/MTU/port enable/disable " Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 10/14] net: dsa: qca8k: move port FDB/MDB function " Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 11/14] net: dsa: qca8k: move port mirror functions " Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 12/14] net: dsa: qca8k: move port VLAN " Christian Marangi
2022-07-23 14:18 ` [net-next PATCH v3 13/14] net: dsa: qca8k: move port LAG " Christian Marangi
2022-07-23 14:18 ` Christian Marangi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220723141845.10570-15-ansuelsmth@gmail.com \
    --to=ansuelsmth@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox