From: Steven Rostedt <rostedt@goodmis.org>
To: Jianlin Lv <iecedge@gmail.com>
Cc: mingo@redhat.com, jianlv@ebay.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/kprobe: Add tracefs to show private kprobe
Date: Sun, 24 Jul 2022 19:19:31 -0400 [thread overview]
Message-ID: <20220724191931.60c671e2@rorschach.local.home> (raw)
In-Reply-To: <20220724091050.12711-1-iecedge@gmail.com>
On Sun, 24 Jul 2022 09:10:50 +0000
Jianlin Lv <iecedge@gmail.com> wrote:
> List private kprobe event to new created local_event_list;
> Add tracefs file kprobe_local_profile to show events which
> in local_event_list.
This states what you are doing, but not why you are doing it.
The subject of a commit should be the what, and the body should explain
the why.
And the subject is confusing because you are not "adding tracefs", it
should state:
tracing/kprobes: Add method to display private kprobes in tracefs
Or something like that.
-- Steve
prev parent reply other threads:[~2022-07-24 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 9:10 [PATCH] tracing/kprobe: Add tracefs to show private kprobe Jianlin Lv
2022-07-24 23:19 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220724191931.60c671e2@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=iecedge@gmail.com \
--cc=jianlv@ebay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox