Re: [PATCH v1 1/8] media: ov2740: Remove duplicative pointer in struct nvm_data

Andy Shevchenko
2022-11-11T19:48:02Z

On Fri, Nov 11, 2022 at 07:41:28PM +0000, Sakari Ailus wrote:
> On Fri, Nov 11, 2022 at 05:29:16PM +0200, Andy Shevchenko wrote:
> > On Fri, Nov 11, 2022 at 02:58:45PM +0000, Sakari Ailus wrote:
> > > On Fri, Nov 11, 2022 at 02:08:48PM +0200, Andy Shevchenko wrote:
> > > > On Fri, Nov 11, 2022 at 02:05:37PM +0200, Andy Shevchenko wrote:
> > > > > On Tue, Aug 23, 2022 at 05:10:35PM +0300, Andy Shevchenko wrote:
> > > > > > On Tue, Jul 26, 2022 at 03:05:49PM +0300, Andy Shevchenko wrote:
> > > > > > > The struct i2c_client pointer is used only to get driver data,
> > > > > > > associated with a struct device or print messages on behalf.
> > > > > > > Moreover, the very same pointer to a struct device is already
> > > > > > > assigned by a regmap and can be retrieved from there.
> > > > > > > No need to keep a duplicative pointer.
> > > > > >
> > > > > > Thanks, Bungbu, for the review. Can it be now applied?
> > > > >
> > > > > Don't see this being applied or commented why not...
> > > > >
> > > > > Mauro? Or who is taking care of this driver nowadays?
> > > >
> > > > Okay, found a private response by Mauro where he tells that Sakari can take
> > > > care of this. Sakari, should I resend this to you with all tags applied?
> > > > Or you can use `b4` tool that allows to avoid unneeded resend.
> > >
> > > No need to. But please cc me on the next time. I'll take a look now...
> >
> > How should I know whom to Cc? Can we update MAINTAINERS accordingly, please?
>
> Good question. In media tree we've listed the maintainers in wiki, as
> the information would be hard to keep up-to-date file-wise:
>
> <URL:https://www.linuxtv.org/wiki/index.php/Media_Maintainers>

Unfortunately get_maintainer.pl doesn't know about this.

> So it helps if you cc me to camera sensor driver patches, but they're
> neither ignored if you don't. It usually takes a little bit more time
> but not nearly as much as this time.
>
> Cc Hans.

--
With Best Regards,
Andy Shevchenko