From: Bjorn Helgaas <helgaas@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Selvam Sathappan Periakaruppan" <quic_speriaka@quicinc.com>,
"Baruch Siach" <baruch.siach@siklu.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Robert Marko" <robimarko@gmail.com>,
"Christian Marangi" <ansuelsmth@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH 1/2] PCI: qcom: Drop unnecessary <linux/interrupt.h> include
Date: Wed, 27 Jul 2022 14:28:11 -0500 [thread overview]
Message-ID: <20220727192811.GA218230@bhelgaas> (raw)
In-Reply-To: <Yt/cOnW6R9ONnFyW@hovoldconsulting.com>
On Tue, Jul 26, 2022 at 02:21:14PM +0200, Johan Hovold wrote:
> On Fri, Jul 22, 2022 at 10:49:18AM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > pcie-qcom.c uses nothing from <linux/interrupt.h>, so remove the
> > unnecessary include of it.
>
> Appears to be unused since commit 7c5925afbc58 ("PCI: dwc: Move MSI IRQs
> allocation to IRQ domains hierarchical API") so there may be other
> driver that also no longer need it.
Thanks for digging that out! You're right, there's a long list of
drivers that include <linux/interrupt.h> but don't appear to need it.
I'm going to drop this patch and try to do them all at once.
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
next prev parent reply other threads:[~2022-07-27 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 15:49 [PATCH 0/2] PCI: qcom: Minor cleanup Bjorn Helgaas
2022-07-22 15:49 ` [PATCH 1/2] PCI: qcom: Drop unnecessary <linux/interrupt.h> include Bjorn Helgaas
2022-07-26 12:21 ` Johan Hovold
2022-07-27 19:28 ` Bjorn Helgaas [this message]
2022-07-22 15:49 ` [PATCH 2/2] PCI: qcom: Sort variants by Qcom IP rev Bjorn Helgaas
2022-07-26 12:45 ` Johan Hovold
2022-07-27 22:02 ` Bjorn Helgaas
2022-07-28 12:26 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727192811.GA218230@bhelgaas \
--to=helgaas@kernel.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=baruch.siach@siklu.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=quic_speriaka@quicinc.com \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox