From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDFC7C3F6B0 for ; Fri, 29 Jul 2022 09:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235374AbiG2JFj (ORCPT ); Fri, 29 Jul 2022 05:05:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235431AbiG2JFf (ORCPT ); Fri, 29 Jul 2022 05:05:35 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C97D2610F for ; Fri, 29 Jul 2022 02:05:34 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHLvo-0006wl-0v; Fri, 29 Jul 2022 11:05:16 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oHLvl-0000iK-61; Fri, 29 Jul 2022 11:05:13 +0200 Date: Fri, 29 Jul 2022 11:05:13 +0200 From: Oleksij Rempel To: Andrew Lunn Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net v1 1/1] net: dsa: microchip: don't try do read Gbit registers on non Gbit chips Message-ID: <20220729090513.GA10850@pengutronix.de> References: <20220728131725.40492-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2022 at 03:25:35PM +0200, Andrew Lunn wrote: > On Thu, Jul 28, 2022 at 03:17:25PM +0200, Oleksij Rempel wrote: > > Do not try to read not existing or wrong register on chips without > > GBIT_SUPPORT. > > > > Fixes: c2e866911e25 ("net: dsa: microchip: break KSZ9477 DSA driver into two files") > > Signed-off-by: Oleksij Rempel > > --- > > drivers/net/dsa/microchip/ksz9477.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c > > index c73bb6d383ad..f6bbd9646c85 100644 > > --- a/drivers/net/dsa/microchip/ksz9477.c > > +++ b/drivers/net/dsa/microchip/ksz9477.c > > @@ -316,7 +316,13 @@ void ksz9477_r_phy(struct ksz_device *dev, u16 addr, u16 reg, u16 *data) > > break; > > } > > } else { > > - ksz_pread16(dev, addr, 0x100 + (reg << 1), &val); > > + /* No gigabit support. Do not read wrong registers. */ > > + if (!(dev->features & GBIT_SUPPORT) && > > + (reg == MII_CTRL1000 || reg == MII_ESTATUS || > > + reg == MII_STAT1000)) > > Does this actually happen? > > If i remember this code correctly, it tries to make the oddly looking > PHY look like a normal PHY. phylib is then used to drive the PHY? > > If i have that correct, why is phylib trying to read these registers? > It should know there is no 1G support, and should skip them. It looks like currently undocumented silicon errata. According to the data sheet, the BMSR_ESTATEN should not be set BMSR_ERCAP, but this bits are set. The question is what is the proper place to implement it. There is same PHYid for most KSZ switch PHYs, it is no possible to detect it by PHYid. I have following options: - add chips specific quirk in the ksz9477_r_phy(), just remove BMSR_ESTATEN and BMSR_ERCAP. - notify about errata over get_phy_flags and implement get_caps quirk in the PHY driver. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |