From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE30C00140 for ; Fri, 29 Jul 2022 03:37:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233979AbiG2DhU (ORCPT ); Thu, 28 Jul 2022 23:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233416AbiG2DhR (ORCPT ); Thu, 28 Jul 2022 23:37:17 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4CA47B375; Thu, 28 Jul 2022 20:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659065835; x=1690601835; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=C/xHBwduANxCzYkbEEJbzvCivYL1kPWDOwmRSCJDTzE=; b=SUlZ/NA52Qm9UTCm9r5p8t+dexNyl3fstcuXNeHh9O33PQuca5kUrKK9 oMqZA8QYMRi8yZp1jfumdLoOvM+yreq3Q4ZsOsLUSPXTU/KWWigGuOdBR HLQQBcria3LwtqkyoTSn5i0JqvHPvAmhS80hLNvDqYXdgQzCyj6Rq8Ey6 9BJWK7XhCK5TAlc5B9By2rTQDMCJWsgS/p4dL7if/5I6JM+4sIknu4ooK mCMFyNXmlUH9Ka0YVJZvcDUHC3i9/9/dlHG0G5BqvI8KBQLMLnA/ez2Z2 2V10ch0ScgfOITPoHFoc0HEVJRSRSJMmrCF6BT33y9Q66SbfoZ4yJv0qf w==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="271721566" X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="271721566" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 20:37:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="928588712" Received: from lkp-server01.sh.intel.com (HELO e0eace57cfef) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 28 Jul 2022 20:37:13 -0700 Received: from kbuild by e0eace57cfef with local (Exim 4.96) (envelope-from ) id 1oHGoL-000B0Y-0T; Fri, 29 Jul 2022 03:37:13 +0000 Date: Fri, 29 Jul 2022 11:36:15 +0800 From: kernel test robot To: Andy Shevchenko , Damien Le Moal , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Andy Shevchenko Subject: Re: [PATCH v1 1/1] ata: libata-scsi: Refactor scsi_6_lba_len() with use of get_unaligned_be24() Message-ID: <202207291100.qslmQQl1-lkp@intel.com> References: <20220726154518.73248-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220726154518.73248-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.19-rc8 next-20220728] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ata-libata-scsi-Refactor-scsi_6_lba_len-with-use-of-get_unaligned_be24/20220726-234746 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e0dccc3b76fb35bb257b4118367a883073d7390e config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220729/202207291100.qslmQQl1-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/ae9a00d0e0375aa2aea7a61dc2894d9d06005f8e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/ata-libata-scsi-Refactor-scsi_6_lba_len-with-use-of-get_unaligned_be24/20220726-234746 git checkout ae9a00d0e0375aa2aea7a61dc2894d9d06005f8e # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ata/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/ata/libata-scsi.c: In function 'scsi_6_lba_len': >> drivers/ata/libata-scsi.c:1320:39: warning: passing argument 1 of 'get_unaligned_be24' makes pointer from integer without a cast [-Wint-conversion] 1320 | *plba = get_unaligned_be24(cdb[1]) & 0x1fffff; | ~~~^~~ | | | u8 {aka unsigned char} In file included from ./arch/x86/include/generated/asm/unaligned.h:1, from drivers/ata/libata-scsi.c:33: include/asm-generic/unaligned.h:90:50: note: expected 'const void *' but argument is of type 'u8' {aka 'unsigned char'} 90 | static inline u32 get_unaligned_be24(const void *p) | ~~~~~~~~~~~~^ vim +/get_unaligned_be24 +1320 drivers/ata/libata-scsi.c 1307 1308 /** 1309 * scsi_6_lba_len - Get LBA and transfer length 1310 * @cdb: SCSI command to translate 1311 * 1312 * Calculate LBA and transfer length for 6-byte commands. 1313 * 1314 * RETURNS: 1315 * @plba: the LBA 1316 * @plen: the transfer length 1317 */ 1318 static void scsi_6_lba_len(const u8 *cdb, u64 *plba, u32 *plen) 1319 { > 1320 *plba = get_unaligned_be24(cdb[1]) & 0x1fffff; 1321 *plen = cdb[4]; 1322 } 1323 -- 0-DAY CI Kernel Test Service https://01.org/lkp