Re: [PATCH v2 2/3] staging: rtl8192u: move debug files to debugfs

Greg Kroah-Hartman
2022-07-19T13:39:40Z

On Mon, Jul 18, 2022 at 10:50:37PM -0700, Tong Zhang wrote:
> There are 4 debug files created under /proc/net/[Devname]. Devname could
> Due to this is purely for debuging as files are created read only,
> move this to debugfs like other NIC drivers do instead of using procfs.
> This is also to prepare for address rmmod warn issue.

Minor comments based on good debugfs usage:

> --- a/drivers/staging/rtl8192u/r8192U.h
> +++ b/drivers/staging/rtl8192u/r8192U.h
> @@ -1061,6 +1061,9 @@ typedef struct r8192_priv {
> struct delayed_work gpio_change_rf_wq;
> struct delayed_work initialgain_operate_wq;
> struct workqueue_struct *priv_wq;
> +
> + /* debugfs */
> + struct dentry *debugfs_dir;

Why do you need to save this dentry? Can't you just look it up when you
want to remove the files?

> +void rtl8192_debugfs_init(struct net_device *dev)
> {
> - struct proc_dir_entry *dir;
> + struct dentry *dir;
> + struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);

No need to cast this. Same for later on in this file.

> - if (!rtl8192_proc)
> + dir = debugfs_create_dir(dev->name, NULL);
> + if (IS_ERR(dir))
> return;

No need to check, just keep moving on.

>
> - dir = proc_mkdir_data(dev->name, 0, rtl8192_proc, dev);
> - if (!dir)
> - return;
> + debugfs_create_file("stats-rx", 0444, dir, dev, &rtl8192_usb_stats_rx_fops);
> + debugfs_create_file("stats-tx", 0444, dir, dev, &rtl8192_usb_stats_tx_fops);
> + debugfs_create_file("stats-ap", 0444, dir, dev, &rtl8192_usb_stats_ap_fops);
> + debugfs_create_file("registers", 0444, dir, dev, &rtl8192_usb_registers_fops);
>
> - proc_create_single("stats-rx", S_IFREG | 0444, dir,
> - proc_get_stats_rx);
> - proc_create_single("stats-tx", S_IFREG | 0444, dir,
> - proc_get_stats_tx);
> - proc_create_single("stats-ap", S_IFREG | 0444, dir,
> - proc_get_stats_ap);
> - proc_create_single("registers", S_IFREG | 0444, dir,
> - proc_get_registers);
> + priv->debugfs_dir = dir;

Again, no need to save this, just look it up when removing the
directory.

thanks,

greg k-h