From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F12DC00140 for ; Sun, 31 Jul 2022 20:13:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238145AbiGaUNF (ORCPT ); Sun, 31 Jul 2022 16:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237944AbiGaUNA (ORCPT ); Sun, 31 Jul 2022 16:13:00 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19546E0F3 for ; Sun, 31 Jul 2022 13:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659298380; x=1690834380; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=iS/WvWpNtmeUiDZfj9nj3YoDnEgHJ3SA5LrEl1d5afM=; b=QrCT1YLWD2iPkTAdrtwgn0ybiVYrsf1Rato6UX00M5mj5Knu6bJmdkOE jOM85x3Fgf9m0PIxyXO/5sQI80QPMI8dogCWtK0LzIjaA3h1xwAvlLoQR ZnQ9/jk/nzlUaiBtNOgP3XZUsW0pgGK8MpLeZcyjm0locdiQKXnmpFndu WkWn+h57t9bdJVoDxyEiE7yXzJxGMsCmd8jl5tWRq/KHTQt7NHKxD14YU QQx45XrbgyiCnMVN8iV3KZ5lMVwTFEs3Nn3QvCmEFOQ8YpBGeFBplnImU qlGiK/af7+wJz3DdKw3sOQwaPw86JwR4291H0gBpcSkradTodzSzbuCKs w==; X-IronPort-AV: E=McAfee;i="6400,9594,10425"; a="287779678" X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="287779678" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2022 13:12:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="929327769" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 31 Jul 2022 13:12:57 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3C05FF1; Sun, 31 Jul 2022 23:13:07 +0300 (EEST) From: Andy Shevchenko To: Lee Jones , Andy Shevchenko , Hans de Goede , linux-kernel@vger.kernel.org Cc: Lee Jones , Andy Shevchenko , Christophe JAILLET Subject: [PATCH v2 01/10] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Sun, 31 Jul 2022 23:12:49 +0300 Message-Id: <20220731201258.11262-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko --- v2: new patch drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 5e8c94e008ed..85d070bce0e2 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -77,6 +77,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; } -- 2.35.1