Re: [PATCH 5.18 72/88] mptcp: dont send RST for single subflow

Sasha Levin
2022-08-02T21:21:13Z

On Tue, Aug 02, 2022 at 01:52:15PM -0700, Mat Martineau wrote:
>On Mon, 1 Aug 2022, Greg Kroah-Hartman wrote:
>
>>From: Geliang Tang <geliang.tang@suse.com>
>>
>>[ Upstream commit 1761fed2567807f26fbd53032ff622f55978c7a9 ]
>>
>>When a bad checksum is detected and a single subflow is in use, don't
>>send RST + MP_FAIL, send data_ack + MP_FAIL instead.
>>
>>So invoke tcp_send_active_reset() only when mptcp_has_another_subflow()
>>is true.
>>
>>Signed-off-by: Geliang Tang <geliang.tang@suse.com>
>>Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
>>Signed-off-by: David S. Miller <davem@davemloft.net>
>>Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Hi Greg -
>
>Please drop this patch from the 5.18-stable queue. It was the first of
>an 8-patch series and doesn't really stand alone.
>
>This commit message lacks the Fixes: tag and the magic commit message
>words that I've seen the scripts pick up, so I'm curious: was this
>patch selected by hand?

Yup, between the commit message and the code itself, it looked like a
fix for AUTOSEL.

--
Thanks,
Sasha