From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531E9C00144 for ; Mon, 1 Aug 2022 11:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbiHALmI (ORCPT ); Mon, 1 Aug 2022 07:42:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbiHALmG (ORCPT ); Mon, 1 Aug 2022 07:42:06 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA78F33372 for ; Mon, 1 Aug 2022 04:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659354125; x=1690890125; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GuzQiJ2YB1b08Bw3C4FZ4eXUc4rZ/ThGZYAuDfVZj2Y=; b=VzSASqkbxgMAUFXSHm8US0MQmEFSkky58008WJ/nr4CtuUKaW15la5R5 sGCCZh9ev5mvk5uoCL5y0EWRh27LxuX/+cBW/4PFz8HbQBBlDvNrYB/kj BTpmocdt6B0/ccsQ6bLccaddlbX8lFJoCMT8cGa9iDOqu4QgKk932GMx3 Radz3Yu6JKphwMLonx6zhhgVLdbglVkRkpmpDlGLLF+I3sXJiXGHuUCZG qxmpy2hi7g70WA3RiTzNFMh2N4/2nJ4+WJazpHB1gV0zDniyC7DpE/+n0 NApOyfBbYwO/O/t/UtMgrkyjBw8as3RV2x32pQAwc9OUod6wZOo//l4Lg A==; X-IronPort-AV: E=McAfee;i="6400,9594,10425"; a="286683361" X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="286683361" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2022 04:42:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="598909957" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2022 04:42:03 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id DF527F7; Mon, 1 Aug 2022 14:42:13 +0300 (EEST) From: Andy Shevchenko To: Lee Jones , Andy Shevchenko , Hans de Goede , linux-kernel@vger.kernel.org Cc: Lee Jones , Andy Shevchenko , Christophe JAILLET Subject: [PATCH v3 01/10] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Mon, 1 Aug 2022 14:42:02 +0300 Message-Id: <20220801114211.36267-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede --- v3: added tag (Hans) v2: new patch drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 5e8c94e008ed..85d070bce0e2 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -77,6 +77,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; } -- 2.35.1