Re: [V2 01/11] KVM: selftests: move vm_phy_pages_alloc() earlier in file

Andrew Jones
2022-08-02T10:00:01Z

On Mon, Aug 01, 2022 at 01:10:59PM -0700, Peter Gonda wrote:
> From: Michael Roth <michael.roth@amd.com>
>
> Subsequent patches will break some of this code out into file-local
> helper functions, which will be used by functions like vm_vaddr_alloc(),
> which currently are defined earlier in the file, so a forward
> declaration would be needed.
>
> Instead, move it earlier in the file, just above vm_vaddr_alloc() and
> and friends, which are the main users.
>
> Reviewed-by: Mingwei Zhang <mizhang@google.com>
> Signed-off-by: Michael Roth <michael.roth@amd.com>
> Signed-off-by: Peter Gonda <pgonda@google.com>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 145 ++++++++++-----------
> 1 file changed, 72 insertions(+), 73 deletions(-)
>

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>