Re: [PATCH v1 1/1] leds: an30259a: Get rid of custom led_init_default_state_get()

kernel test robot
2022-08-03T01:26:48Z

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on pavel-leds/for-next]
[also build test ERROR on linus/master v5.19 next-20220728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/leds-an30259a-Get-rid-of-custom-led_init_default_state_get/20220803-053038
base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: x86_64-randconfig-a005-20220801 (https://download.01.org/0day-ci/archive/20220803/202208030939.UxKQfaZY-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/757448b8fc5bcbc4303ce9570d5dd555f1e2b22e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/leds-an30259a-Get-rid-of-custom-led_init_default_state_get/20220803-053038
git checkout 757448b8fc5bcbc4303ce9570d5dd555f1e2b22e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/leds/leds-an30259a.c:227:24: error: call to undeclared function 'led_init_default_state_get'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
led->default_state = led_init_default_state_get(led->fwnode);
^
drivers/leds/leds-an30259a.c:204:14: warning: unused variable 'str' [-Wunused-variable]
const char *str;
^
1 warning and 1 error generated.

vim +/led_init_default_state_get +227 drivers/leds/leds-an30259a.c

197
198 static int an30259a_dt_init(struct i2c_client *client,
199 struct an30259a *chip)
200 {
201 struct device_node *np = dev_of_node(&client->dev), *child;
202 int count, ret;
203 int i = 0;
204 const char *str;
205 struct an30259a_led *led;
206
207 count = of_get_available_child_count(np);
208 if (!count || count > AN30259A_MAX_LEDS)
209 return -EINVAL;
210
211 for_each_available_child_of_node(np, child) {
212 u32 source;
213
214 ret = of_property_read_u32(child, "reg", &source);
215 if (ret != 0 || !source || source > AN30259A_MAX_LEDS) {
216 dev_err(&client->dev, "Couldn't read LED address: %d\n",
217 ret);
218 count--;
219 continue;
220 }
221
222 led = &chip->leds[i];
223
224 led->num = source;
225 led->chip = chip;
226 led->fwnode = of_fwnode_handle(child);
> 227 led->default_state = led_init_default_state_get(led->fwnode);
228
229 i++;
230 }
231
232 if (!count)
233 return -EINVAL;
234
235 chip->num_leds = i;
236
237 return 0;
238 }
239