From: kernel test robot <lkp@intel.com>
To: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
"Matthew Auld" <matthew.auld@intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Priyanka Dandamudi" <priyanka.dandamudi@intel.com>,
"Nirmoy Das" <nirmoy.das@intel.com>
Subject: drivers/gpu/drm/i915/gt/intel_region_lmem.c:70:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false
Date: Sun, 7 Aug 2022 08:35:12 +0800 [thread overview]
Message-ID: <202208070818.09hru8ga-lkp@intel.com> (raw)
Hi Akeem,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4d1044fcb996e8de9b9ab392f4a767890e45202d
commit: a91d1a17cd341548fd9535e33c331a2756acdfae drm/i915: Add support for LMEM PCIe resizable bar
date: 3 weeks ago
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220807/202208070818.09hru8ga-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 26dd42705c2af0b8f6e5d6cdb32c9bd5ed9524eb)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a91d1a17cd341548fd9535e33c331a2756acdfae
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a91d1a17cd341548fd9535e33c331a2756acdfae
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gt/intel_region_lmem.c:70:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
root_res->start > 0x100000000ull)
~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
1 error generated.
vim +70 drivers/gpu/drm/i915/gt/intel_region_lmem.c
46
47 #define LMEM_BAR_NUM 2
48 static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size)
49 {
50 struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
51 struct pci_bus *root = pdev->bus;
52 struct resource *root_res;
53 resource_size_t rebar_size;
54 u32 pci_cmd;
55 int i;
56
57 rebar_size = roundup_pow_of_two(pci_resource_len(pdev, LMEM_BAR_NUM));
58
59 if (rebar_size != roundup_pow_of_two(lmem_size))
60 rebar_size = lmem_size;
61 else
62 return;
63
64 /* Find out if root bus contains 64bit memory addressing */
65 while (root->parent)
66 root = root->parent;
67
68 pci_bus_for_each_resource(root, root_res, i) {
69 if (root_res && root_res->flags & (IORESOURCE_MEM | IORESOURCE_MEM_64) &&
> 70 root_res->start > 0x100000000ull)
71 break;
72 }
73
74 /* pci_resize_resource will fail anyways */
75 if (!root_res) {
76 drm_info(&i915->drm, "Can't resize LMEM BAR - platform support is missing\n");
77 return;
78 }
79
80 /* First disable PCI memory decoding references */
81 pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
82 pci_write_config_dword(pdev, PCI_COMMAND,
83 pci_cmd & ~PCI_COMMAND_MEMORY);
84
85 _resize_bar(i915, LMEM_BAR_NUM, rebar_size);
86
87 pci_assign_unassigned_bus_resources(pdev->bus);
88 pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
89 }
90
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-08-07 0:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208070818.09hru8ga-lkp@intel.com \
--to=lkp@intel.com \
--cc=akeem.g.abodunrin@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=matthew.auld@intel.com \
--cc=michal.winiarski@intel.com \
--cc=nirmoy.das@intel.com \
--cc=priyanka.dandamudi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox