public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>,
	Paul Moore <paul@paul-moore.com>, Sasha Levin <sashal@kernel.org>,
	stephen.smalley.work@gmail.com, eparis@parisplace.org,
	selinux@vger.kernel.org
Subject: [PATCH AUTOSEL 5.4 23/23] selinux: Add boundary check in put_entry()
Date: Sun,  7 Aug 2022 21:38:30 -0400	[thread overview]
Message-ID: <20220808013832.316381-23-sashal@kernel.org> (raw)
In-Reply-To: <20220808013832.316381-1-sashal@kernel.org>

From: Xiu Jianfeng <xiujianfeng@huawei.com>

[ Upstream commit 15ec76fb29be31df2bccb30fc09875274cba2776 ]

Just like next_entry(), boundary check is necessary to prevent memory
out-of-bound access.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 security/selinux/ss/policydb.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/security/selinux/ss/policydb.h b/security/selinux/ss/policydb.h
index 162d0e79b85b..b18bc405f820 100644
--- a/security/selinux/ss/policydb.h
+++ b/security/selinux/ss/policydb.h
@@ -356,6 +356,8 @@ static inline int put_entry(const void *buf, size_t bytes, int num, struct polic
 {
 	size_t len = bytes * num;
 
+	if (len > fp->len)
+		return -EINVAL;
 	memcpy(fp->data, buf, len);
 	fp->data += len;
 	fp->len -= len;
-- 
2.35.1


      parent reply	other threads:[~2022-08-08  1:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08  1:38 [PATCH AUTOSEL 5.4 01/23] x86: Handle idle=nomwait cmdline properly for x86_idle Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 02/23] arm64: Do not forget syscall when starting a new thread Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 03/23] arm64: fix oops in concurrently setting insn_emulation sysctls Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 04/23] ext2: Add more validity checks for inode counts Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 05/23] genirq: Don't return error on missing optional irq_request_resources() Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 06/23] genirq: GENERIC_IRQ_IPI depends on SMP Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 07/23] wait: Fix __wait_event_hrtimeout for RT/DL tasks Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 08/23] ARM: dts: imx6ul: add missing properties for sram Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 09/23] ARM: dts: imx6ul: change operating-points to uint32-matrix Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 10/23] ARM: dts: imx6ul: fix csi node compatible Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 11/23] ARM: dts: imx6ul: fix lcdif " Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 12/23] ARM: dts: imx6ul: fix qspi " Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 13/23] spi: synquacer: Add missing clk_disable_unprepare() Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 14/23] ARM: OMAP2+: display: Fix refcount leak bug Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 15/23] ACPI: EC: Remove duplicate ThinkPad X1 Carbon 6th entry from DMI quirks Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 16/23] ACPI: PM: save NVS memory for Lenovo G40-45 Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 17/23] ACPI: LPSS: Fix missing check in register_device_clock() Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 18/23] arm64: dts: qcom: ipq8074: fix NAND node name Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 19/23] arm64: dts: allwinner: a64: orangepi-win: Fix LED " Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 20/23] ARM: shmobile: rcar-gen2: Increase refcount for new reference Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 21/23] hwmon: (sht15) Fix wrong assumptions in device remove callback Sasha Levin
2022-08-08  1:38 ` [PATCH AUTOSEL 5.4 22/23] PM: hibernate: defer device probing when resuming from hibernation Sasha Levin
2022-08-08  1:38 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808013832.316381-23-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=eparis@parisplace.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=selinux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    --cc=xiujianfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox