From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Samuel Holland <samuel@sholland.org>,
kernel test robot <lkp@intel.com>, Marc Zyngier <maz@kernel.org>,
Sasha Levin <sashal@kernel.org>,
tglx@linutronix.de
Subject: [PATCH AUTOSEL 4.14 04/12] genirq: GENERIC_IRQ_IPI depends on SMP
Date: Sun, 7 Aug 2022 21:39:34 -0400 [thread overview]
Message-ID: <20220808013943.316907-4-sashal@kernel.org> (raw)
In-Reply-To: <20220808013943.316907-1-sashal@kernel.org>
From: Samuel Holland <samuel@sholland.org>
[ Upstream commit 0f5209fee90b4544c58b4278d944425292789967 ]
The generic IPI code depends on the IRQ affinity mask being allocated
and initialized. This will not be the case if SMP is disabled. Fix up
the remaining driver that selected GENERIC_IRQ_IPI in a non-SMP config.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220701200056.46555-3-samuel@sholland.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/irqchip/Kconfig | 2 +-
kernel/irq/Kconfig | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 9d8a1dd2e2c2..602602d7017b 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -138,7 +138,7 @@ config IMGPDC_IRQ
config IRQ_MIPS_CPU
bool
select GENERIC_IRQ_CHIP
- select GENERIC_IRQ_IPI if SYS_SUPPORTS_MULTITHREADING
+ select GENERIC_IRQ_IPI if SMP && SYS_SUPPORTS_MULTITHREADING
select IRQ_DOMAIN
select IRQ_DOMAIN_HIERARCHY if GENERIC_IRQ_IPI
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
index 779d858da2b3..94fb3ad9e275 100644
--- a/kernel/irq/Kconfig
+++ b/kernel/irq/Kconfig
@@ -80,6 +80,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
# Generic IRQ IPI support
config GENERIC_IRQ_IPI
bool
+ depends on SMP
select IRQ_DOMAIN_HIERARCHY
# Generic MSI interrupt support
--
2.35.1
next prev parent reply other threads:[~2022-08-08 1:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 1:39 [PATCH AUTOSEL 4.14 01/12] arm64: Do not forget syscall when starting a new thread Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 02/12] arm64: fix oops in concurrently setting insn_emulation sysctls Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 03/12] ext2: Add more validity checks for inode counts Sasha Levin
2022-08-08 1:39 ` Sasha Levin [this message]
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 05/12] ARM: dts: imx6ul: add missing properties for sram Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 06/12] ARM: dts: imx6ul: fix qspi node compatible Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 07/12] ARM: OMAP2+: display: Fix refcount leak bug Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 08/12] ACPI: PM: save NVS memory for Lenovo G40-45 Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 09/12] ACPI: LPSS: Fix missing check in register_device_clock() Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 10/12] hwmon: (sht15) Fix wrong assumptions in device remove callback Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 11/12] PM: hibernate: defer device probing when resuming from hibernation Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.14 12/12] selinux: Add boundary check in put_entry() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808013943.316907-4-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maz@kernel.org \
--cc=samuel@sholland.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox