From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>,
Paul Moore <paul@paul-moore.com>, Sasha Levin <sashal@kernel.org>,
stephen.smalley.work@gmail.com, eparis@parisplace.org,
selinux@vger.kernel.org
Subject: [PATCH AUTOSEL 4.9 8/8] selinux: Add boundary check in put_entry()
Date: Sun, 7 Aug 2022 21:40:03 -0400 [thread overview]
Message-ID: <20220808014005.317064-8-sashal@kernel.org> (raw)
In-Reply-To: <20220808014005.317064-1-sashal@kernel.org>
From: Xiu Jianfeng <xiujianfeng@huawei.com>
[ Upstream commit 15ec76fb29be31df2bccb30fc09875274cba2776 ]
Just like next_entry(), boundary check is necessary to prevent memory
out-of-bound access.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
security/selinux/ss/policydb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/security/selinux/ss/policydb.h b/security/selinux/ss/policydb.h
index 725d5945a97e..178d8804ecb1 100644
--- a/security/selinux/ss/policydb.h
+++ b/security/selinux/ss/policydb.h
@@ -349,6 +349,8 @@ static inline int put_entry(const void *buf, size_t bytes, int num, struct polic
{
size_t len = bytes * num;
+ if (len > fp->len)
+ return -EINVAL;
memcpy(fp->data, buf, len);
fp->data += len;
fp->len -= len;
--
2.35.1
prev parent reply other threads:[~2022-08-08 2:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 1:39 [PATCH AUTOSEL 4.9 1/8] arm64: fix oops in concurrently setting insn_emulation sysctls Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.9 2/8] ext2: Add more validity checks for inode counts Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.9 3/8] ARM: dts: imx6ul: add missing properties for sram Sasha Levin
2022-08-08 1:39 ` [PATCH AUTOSEL 4.9 4/8] ARM: dts: imx6ul: fix qspi node compatible Sasha Levin
2022-08-08 1:40 ` [PATCH AUTOSEL 4.9 5/8] ACPI: LPSS: Fix missing check in register_device_clock() Sasha Levin
2022-08-08 1:40 ` [PATCH AUTOSEL 4.9 6/8] hwmon: (sht15) Fix wrong assumptions in device remove callback Sasha Levin
2022-08-08 1:40 ` [PATCH AUTOSEL 4.9 7/8] PM: hibernate: defer device probing when resuming from hibernation Sasha Levin
2022-08-08 1:40 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808014005.317064-8-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox