* [PATCH] perf tools: Fix missing free of machine->kallsyms_filename
@ 2022-08-09 13:07 Adrian Hunter
2022-08-09 16:51 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Hunter @ 2022-08-09 13:07 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Jiri Olsa, Namhyung Kim, Ian Rogers, linux-kernel
Add missing free of machine->kallsyms_filename to machine__exit().
Fixes: a5367ecb5353 ("perf tools: Automatically use guest kcore_dir if present")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/machine.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index facc13fbf16e..2a16cae28407 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -236,6 +236,7 @@ void machine__exit(struct machine *machine)
zfree(&machine->root_dir);
zfree(&machine->mmap_name);
zfree(&machine->current_tid);
+ zfree(&machine->kallsyms_filename);
for (i = 0; i < THREADS__TABLE_SIZE; i++) {
struct threads *threads = &machine->threads[i];
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf tools: Fix missing free of machine->kallsyms_filename
2022-08-09 13:07 [PATCH] perf tools: Fix missing free of machine->kallsyms_filename Adrian Hunter
@ 2022-08-09 16:51 ` Ian Rogers
2022-08-10 13:20 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2022-08-09 16:51 UTC (permalink / raw)
To: Adrian Hunter
Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Namhyung Kim, linux-kernel
On Tue, Aug 9, 2022 at 6:08 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> Add missing free of machine->kallsyms_filename to machine__exit().
>
> Fixes: a5367ecb5353 ("perf tools: Automatically use guest kcore_dir if present")
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/util/machine.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index facc13fbf16e..2a16cae28407 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -236,6 +236,7 @@ void machine__exit(struct machine *machine)
> zfree(&machine->root_dir);
> zfree(&machine->mmap_name);
> zfree(&machine->current_tid);
> + zfree(&machine->kallsyms_filename);
>
> for (i = 0; i < THREADS__TABLE_SIZE; i++) {
> struct threads *threads = &machine->threads[i];
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf tools: Fix missing free of machine->kallsyms_filename
2022-08-09 16:51 ` Ian Rogers
@ 2022-08-10 13:20 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-08-10 13:20 UTC (permalink / raw)
To: Ian Rogers; +Cc: Adrian Hunter, Jiri Olsa, Namhyung Kim, linux-kernel
Em Tue, Aug 09, 2022 at 09:51:12AM -0700, Ian Rogers escreveu:
> On Tue, Aug 9, 2022 at 6:08 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
> >
> > Add missing free of machine->kallsyms_filename to machine__exit().
> >
> > Fixes: a5367ecb5353 ("perf tools: Automatically use guest kcore_dir if present")
> > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Acked-by: Ian Rogers <irogers@google.com>
Thanks, applied.
- Arnaldo
> Thanks,
> Ian
>
> > ---
> > tools/perf/util/machine.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> > index facc13fbf16e..2a16cae28407 100644
> > --- a/tools/perf/util/machine.c
> > +++ b/tools/perf/util/machine.c
> > @@ -236,6 +236,7 @@ void machine__exit(struct machine *machine)
> > zfree(&machine->root_dir);
> > zfree(&machine->mmap_name);
> > zfree(&machine->current_tid);
> > + zfree(&machine->kallsyms_filename);
> >
> > for (i = 0; i < THREADS__TABLE_SIZE; i++) {
> > struct threads *threads = &machine->threads[i];
> > --
> > 2.25.1
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-10 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-09 13:07 [PATCH] perf tools: Fix missing free of machine->kallsyms_filename Adrian Hunter
2022-08-09 16:51 ` Ian Rogers
2022-08-10 13:20 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox