From: Christoph Hellwig <hch@lst.de>
To: Linjun Bao <meljbao@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: align "fake" nqn with spec 1.3
Date: Wed, 10 Aug 2022 16:08:12 +0200 [thread overview]
Message-ID: <20220810140812.GA24773@lst.de> (raw)
In-Reply-To: <20220810133953.5411-1-meljbao@gmail.com>
On Wed, Aug 10, 2022 at 09:39:54PM +0800, Linjun Bao wrote:
> Replace '.' with '-' to align "fake" nqn format with nvme spec 1.3 or newer.
We can't just change the existing NQN construction if we don't want
to break userspace. Maybe add a comment that it is different from
the canonical version for historic reasons instead.
next prev parent reply other threads:[~2022-08-10 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 13:39 [PATCH] nvme: align "fake" nqn with spec 1.3 Linjun Bao
2022-08-10 14:08 ` Christoph Hellwig [this message]
2022-08-11 7:40 ` [PATCH] nvme: add comment for unaligned "fake" nqn Linjun Bao
2022-09-05 11:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810140812.GA24773@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=meljbao@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox