Re: [V3 10/11] KVM: selftests: Add ucall pool based implementation

Sean Christopherson
2022-08-19T19:37:32Z

On Fri, Aug 19, 2022, Vishal Annapurve wrote:
> On Wed, Aug 10, 2022 at 8:20 AM Peter Gonda <pgonda@google.com> wrote:
> > void ucall(uint64_t cmd, int nargs, ...)
> > {
> > - struct ucall uc = {};
> > + struct ucall *uc;
> > + struct ucall tmp = {};
>
> This steps seems to result in generating instructions that need SSE
> support on x86:
> struct ucall tmp = {};
> movaps %xmm0,0x20(%rsp)
> movaps %xmm0,0x30(%rsp)
> movaps %xmm0,0x40(%rsp)
> movaps %xmm0,0x50(%rsp)
>
> This initialization will need proper compilation flags to generate
> instructions according to VM configuration.

Can you be more specific as to why generating SSE instructiions is problematic?
The compiler emitting fancy instructions for struct initialization is not out of
the ordinary.