From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11C2C00140 for ; Wed, 10 Aug 2022 19:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231232AbiHJTwJ (ORCPT ); Wed, 10 Aug 2022 15:52:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231191AbiHJTwH (ORCPT ); Wed, 10 Aug 2022 15:52:07 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 019616A4B4 for ; Wed, 10 Aug 2022 12:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660161126; x=1691697126; h=date:from:to:cc:subject:message-id:mime-version; bh=Apgw6QHJ5VX9M0jWTe6a5fdwxox8kLToxnwaPR/wBz4=; b=DNaLdlf5kmlQdWbyx8W0pRhQuxHYUH4wZ1no/jsAR4fzaLu8HdhAttFt Jjlh3m84PS5NZK5S4EWQLT4rqspd3i4+jw9LOG51Dnp2JVOJ3N9clIWwS +6m+sFTVqbIT1tEeKwLyyFk+GJcd73AdcO8Gmoh3sPE0a4YV1876e8J7c lcfIiCD8xXgWiZpOPj7ogS8OI+oHV0s7/xCQrJ+3wPa6FOF4rn63Ott/c DpzSBcN1cVcN7SyYwvStosNBLlt7tsD7apysK/qFnvSbzp1h2pH/wMNxL +iyBlvm9WZjYXcCvMN6szUphsq5I7lb6RKaKZMvLcTprC7bShshmXsIyl g==; X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="274232993" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="274232993" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 12:52:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="747551619" Received: from lkp-server02.sh.intel.com (HELO 5d6b42aa80b8) ([10.239.97.151]) by fmsmga001.fm.intel.com with ESMTP; 10 Aug 2022 12:52:04 -0700 Received: from kbuild by 5d6b42aa80b8 with local (Exim 4.96) (envelope-from ) id 1oLrkJ-0000f8-21; Wed, 10 Aug 2022 19:52:03 +0000 Date: Thu, 11 Aug 2022 03:51:07 +0800 From: kernel test robot To: Karsten Graul Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Subject: net/smc/smc_llc.c:40:1: warning: alignment 1 of 'struct smc_llc_hdr' is less than 4 Message-ID: <202208110344.tcjjNU4C-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Karsten, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f41445645ab5d172e6090d00c332c335d8dba337 commit: b4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 net/smc: extend LLC layer for SMC-Rv2 date: 10 months ago config: arm-randconfig-s053-20220810 (https://download.01.org/0day-ci/archive/20220811/202208110344.tcjjNU4C-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout b4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash drivers/net/vmxnet3/ drivers/video/fbdev/aty/ net/smc/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> net/smc/smc_llc.c:40:1: warning: alignment 1 of 'struct smc_llc_hdr' is less than 4 [-Wpacked-not-aligned] 40 | } __packed; /* format defined in | ^ In file included from : net/smc/smc_llc.c: In function 'smc_llc_add_pending_send': include/linux/compiler_types.h:322:45: error: call to '__compiletime_assert_562' declared with attribute error: must increase SMC_WR_BUF_SIZE to at least sizeof(struct smc_llc_msg) 322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:303:25: note: in definition of macro '__compiletime_assert' 303 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert' 322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ net/smc/smc_llc.c:409:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 409 | BUILD_BUG_ON_MSG( | ^~~~~~~~~~~~~~~~ include/linux/compiler_types.h:322:45: error: call to '__compiletime_assert_563' declared with attribute error: must adapt SMC_WR_TX_SIZE to sizeof(struct smc_llc_msg); if not all smc_wr upper layer protocols use the same message size any more, must start to set link->wr_tx_sges[i].length on each individual smc_wr_tx_send() 322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:303:25: note: in definition of macro '__compiletime_assert' 303 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert' 322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ net/smc/smc_llc.c:412:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 412 | BUILD_BUG_ON_MSG( | ^~~~~~~~~~~~~~~~ In function 'smc_llc_send_message_wait', inlined from 'smc_llc_send_link_delete_all' at net/smc/smc_llc.c:1635:8: net/smc/smc_llc.c:785:9: warning: 'memcpy' reading 60 bytes from a region of size 49 [-Wstringop-overread] 785 | memcpy(wr_buf, llcbuf, sizeof(union smc_llc_msg)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all': net/smc/smc_llc.c:1622:37: note: source object 'delllc' of size 49 1622 | struct smc_llc_msg_del_link delllc = {}; | ^~~~~~ vim +40 net/smc/smc_llc.c 23 24 struct smc_llc_hdr { 25 struct smc_wr_rx_hdr common; 26 union { 27 struct { 28 u8 length; /* 44 */ 29 #if defined(__BIG_ENDIAN_BITFIELD) 30 u8 reserved:4, 31 add_link_rej_rsn:4; 32 #elif defined(__LITTLE_ENDIAN_BITFIELD) 33 u8 add_link_rej_rsn:4, 34 reserved:4; 35 #endif 36 }; 37 u16 length_v2; /* 44 - 8192*/ 38 }; 39 u8 flags; > 40 } __packed; /* format defined in 41 * IBM Shared Memory Communications Version 2 42 * (https://www.ibm.com/support/pages/node/6326337) 43 */ 44 -- 0-DAY CI Kernel Test Service https://01.org/lkp