Re: [PATCH v7 1/4] vdpa: Add suspend operation

Dan Carpenter
2022-08-11T12:41:36Z

On Thu, Aug 11, 2022 at 07:23:44AM -0400, Michael S. Tsirkin wrote:
> On Thu, Aug 11, 2022 at 01:15:08PM +0300, Dan Carpenter wrote:
> > On Thu, Aug 11, 2022 at 04:27:32AM -0400, Michael S. Tsirkin wrote:
> > > On Wed, Aug 10, 2022 at 07:15:09PM +0200, Eugenio Pérez wrote:
> > > > This operation is optional: It it's not implemented, backend feature bit
> > > > will not be exposed.
> > > >
> > > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > > > Message-Id: <20220623160738.632852-2-eperezma@redhat.com>
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > What is this message id doing here?
> > >
> >
> > I like the Message-Id tag. It means you can `b4 mbox <mesg-id>` and get
> > the thread.
>
> Yes it makes sense in git. But I don't see what it does in this patch
> posted to the list.

Ah. Okay. I misunderstood.

> It seems to refer to the previous version of the
> patch here. Which is ok I guess but better called out e.g.
>
> Previous-version: <20220623160738.632852-2-eperezma@redhat.com>
>

Let's not go over board with storing previous threads. That seems like
a headache...

regards,
dan carpenter