From: Will McVicker <willmcvicker@google.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: kernel-team@android.com, Sajid Dalvi <sdalvi@google.com>,
Will McVicker <willmcvicker@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1] PCI/PM: Switch D3Hot delay to use usleep_range
Date: Thu, 11 Aug 2022 18:40:01 +0000 [thread overview]
Message-ID: <20220811184001.2512121-1-willmcvicker@google.com> (raw)
From: Sajid Dalvi <sdalvi@google.com>
Since the PCI spec requires a 10ms D3Hot delay (defined by
PCI_PM_D3HOT_WAIT) and a few of the PCI quirks update the D3Hot delay up
to 20ms, let's switch from msleep to usleep_range to improve the delay
accuracy.
This patch came from Sajid Dalvi <sdalvi@google.com> in the Pixel 6
kernel tree [1]. Testing on a Pixel 6, found that the 10ms delay for
the Exynos PCIe device was on average delaying for 19ms when the spec
requires 10ms. Switching from msleep to uslseep_delay therefore
decreases the resume time on a Pixel 6 on average by 9ms.
[1] https://android.googlesource.com/kernel/gs/+/18a8cad68d8e6d50f339a716a18295e6d987cee3
Signed-off-by: Sajid Dalvi <sdalvi@google.com>
Signed-off-by: Will McVicker <willmcvicker@google.com>
---
drivers/pci/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 95bc329e74c0..5ae5b3c4dc9b 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -72,7 +72,8 @@ static void pci_dev_d3_sleep(struct pci_dev *dev)
delay = pci_pm_d3hot_delay;
if (delay)
- msleep(delay);
+ usleep_range(delay * USEC_PER_MSEC,
+ (delay + 2) * USEC_PER_MSEC);
}
bool pci_reset_supported(struct pci_dev *dev)
base-commit: 2ae08b36c06ea8df73a79f6b80ff7964e006e9e3
--
2.37.1.559.g78731f0fdb-goog
next reply other threads:[~2022-08-11 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 18:40 Will McVicker [this message]
2022-08-16 21:06 ` [PATCH v1] PCI/PM: Switch D3Hot delay to use usleep_range Matthias Kaehlcke
2022-08-16 22:17 ` William McVicker
2022-08-16 23:58 ` Matthias Kaehlcke
2022-08-17 18:50 ` William McVicker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811184001.2512121-1-willmcvicker@google.com \
--to=willmcvicker@google.com \
--cc=bhelgaas@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sdalvi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox