From: kernel test robot <lkp@intel.com>
To: bchalios@amazon.es, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, bchalios@amazon.es, tytso@mit.edu,
Jason@zx2c4.com, dwmw@amazon.co.uk, graf@amazon.de,
xmarcalx@amazon.co.uk, gregkh@linuxfoundation.org
Subject: Re: [PATCH 2/2] virt: vmgenid: add support for generation counter
Date: Sun, 14 Aug 2022 11:26:26 +0800 [thread overview]
Message-ID: <202208141147.UE8mhW6c-lkp@intel.com> (raw)
In-Reply-To: <20220803152127.48281-3-bchalios@amazon.es>
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on crng-random/master]
[also build test WARNING on linus/master v5.19 next-20220812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/bchalios-amazon-es/virt-vmgenid-add-generation-counter/20220803-232559
base: git://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git master
reproduce: make htmldocs
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> Documentation/virt/vmgenid.rst:79: WARNING: Inline literal start-string without end-string.
>> Documentation/virt/vmgenid.rst:79: WARNING: Inline emphasis start-string without end-string.
>> Documentation/virt/vmgenid.rst:89: WARNING: Unexpected indentation.
>> Documentation/virt/vmgenid.rst:98: WARNING: Definition list ends without a blank line; unexpected unindent.
>> Documentation/virt/vmgenid.rst:102: WARNING: Inline interpreted text or phrase reference start-string without end-string.
>> Documentation/virt/vmgenid.rst: WARNING: document isn't included in any toctree
vim +79 Documentation/virt/vmgenid.rst
78
> 79 ```
80 uint32_t *gen_cntr = mmaped_gen_counter();
81 uint32_t cached_gen_cntr = *gen_cntr;
82 char *secret;
83
84 for(;;) {
85 secret = get_secret();
86
87 // All good, not restore has happened.
88 if (cached_gen_cntr == *gen_cntr)
> 89 break;
90
91 // Generation counter has changed. We need to recreate caches and try again
92
93 cached_gen_cntr = *gen_cntr;
94 barrier();
95
96 // recreate secrets' cache
97 rebuild_cache();
> 98 }
99
100 consume_secret(secret);
101
> 102 ```
103
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-08-14 3:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 15:21 [PATCH 0/2] virt: vmgenid: add generation counter bchalios
2022-08-03 15:21 ` [PATCH 1/2] virt: vmgenid: add helper function to parse ADDR bchalios
2022-08-03 15:21 ` [PATCH 2/2] virt: vmgenid: add support for generation counter bchalios
2022-08-03 15:28 ` Greg KH
2022-08-03 15:30 ` Greg KH
2022-08-03 17:53 ` Chalios, Babis
2022-08-03 15:31 ` Greg KH
2022-08-03 17:58 ` Chalios, Babis
2022-08-14 3:26 ` kernel test robot [this message]
2022-08-03 15:50 ` [PATCH 0/2] virt: vmgenid: add " Chalios, Babis
2022-08-03 15:57 ` Chalios, Babis
2022-08-04 13:33 ` Chalios, Babis
2022-08-04 14:59 ` Jason A. Donenfeld
2022-08-04 15:46 ` bchalios
2022-08-10 9:19 ` bchalios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208141147.UE8mhW6c-lkp@intel.com \
--to=lkp@intel.com \
--cc=Jason@zx2c4.com \
--cc=bchalios@amazon.es \
--cc=dwmw@amazon.co.uk \
--cc=graf@amazon.de \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xmarcalx@amazon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox