From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CE5C00140 for ; Tue, 16 Aug 2022 00:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344419AbiHPAkP (ORCPT ); Mon, 15 Aug 2022 20:40:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245197AbiHPAjR (ORCPT ); Mon, 15 Aug 2022 20:39:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CEF518C470; Mon, 15 Aug 2022 13:38:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8C573B80EAD; Mon, 15 Aug 2022 20:38:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6809C433D6; Mon, 15 Aug 2022 20:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660595910; bh=Tz6s7IBJFW1EdgkP4qnQqoUkNTXXGbMItPG58G6NuaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2vcABcmYUsU0lIkMB0QkQtrA7Hgr1xSUy7DkrLFkM8WNNJ3G+VsSS5lyb0SRhM4Cs rp2VKtCRPi5KXfl1X2Kmglh0BpKYq3JnOUsT4b16884+fFVY9S00SOWDMcwBd8cdRp 6a2B3WPAFoX8KEw77LTiUcE4TrrgIBKfwd5gcbro= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Hangyu Hua , Mathieu Poirier , Sasha Levin Subject: [PATCH 5.19 0914/1157] rpmsg: Fix possible refcount leak in rpmsg_register_device_override() Date: Mon, 15 Aug 2022 20:04:30 +0200 Message-Id: <20220815180516.015601862@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hangyu Hua [ Upstream commit d7bd416d35121c95fe47330e09a5c04adbc5f928 ] rpmsg_register_device_override need to call put_device to free vch when driver_set_override fails. Fix this by adding a put_device() to the error path. Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Hangyu Hua Link: https://lore.kernel.org/r/20220624024120.11576-1-hbh25y@gmail.com Signed-off-by: Mathieu Poirier Signed-off-by: Sasha Levin --- drivers/rpmsg/rpmsg_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 290c1f02da10..5a47cad89fdc 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -618,6 +618,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev, strlen(driver_override)); if (ret) { dev_err(dev, "device_set_override failed: %d\n", ret); + put_device(dev); return ret; } } -- 2.35.1