From: Ray Chi <raychi@google.com>
To: gregkh@linuxfoundation.org, mathias.nyman@intel.com,
stern@rowland.harvard.edu
Cc: badhri@google.com, albertccwang@google.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Ray Chi <raychi@google.com>
Subject: [PATCH 2/2] usb: xhci: add check_init_status hook support
Date: Tue, 16 Aug 2022 16:38:54 +0800 [thread overview]
Message-ID: <20220816083854.1491886-3-raychi@google.com> (raw)
In-Reply-To: <20220816083854.1491886-1-raychi@google.com>
In general, xHCI didn't do anything for port initialization. However,
there are some requirement or limitation on various platforms, so
vendors need to do some error handlings if the device connected to a
broken USB accessory.
This patch also add the hook to xhci_driver_overrides so that vendors
can add their specific protection easily if needed.
Signed-off-by: Ray Chi <raychi@google.com>
---
drivers/usb/host/xhci.c | 17 +++++++++++++++++
drivers/usb/host/xhci.h | 1 +
2 files changed, 18 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 65858f607437..f237af9d6e2e 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -4358,6 +4358,20 @@ static int xhci_enable_device(struct usb_hcd *hcd, struct usb_device *udev)
return xhci_setup_device(hcd, udev, SETUP_CONTEXT_ONLY);
}
+/*
+ * The function could get the status of port initialization.
+ */
+static int xhci_check_init_status(struct usb_hcd *hcd, struct usb_device *udev, int r)
+{
+ /*
+ * In general, this function is not necessory. Some platforms may
+ * need doing error handling when the port initialization takes a
+ * long time to do. The device can use the override callback to
+ * do specific handlings.
+ */
+ return 0;
+}
+
/*
* Transfer the port index into real index in the HW port status
* registers. Caculate offset between the port's PORTSC register
@@ -5455,6 +5469,7 @@ static const struct hc_driver xhci_hc_driver = {
.enable_device = xhci_enable_device,
.update_hub_device = xhci_update_hub_device,
.reset_device = xhci_discover_or_reset_device,
+ .check_init_status = xhci_check_init_status,
/*
* scheduling support
@@ -5503,6 +5518,8 @@ void xhci_init_driver(struct hc_driver *drv,
drv->check_bandwidth = over->check_bandwidth;
if (over->reset_bandwidth)
drv->reset_bandwidth = over->reset_bandwidth;
+ if (over->check_init_status)
+ drv->check_init_status = over->check_init_status;
}
}
EXPORT_SYMBOL_GPL(xhci_init_driver);
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 1960b47acfb2..33ce873236e9 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1944,6 +1944,7 @@ struct xhci_driver_overrides {
struct usb_host_endpoint *ep);
int (*check_bandwidth)(struct usb_hcd *, struct usb_device *);
void (*reset_bandwidth)(struct usb_hcd *, struct usb_device *);
+ int (*check_init_status)(struct usb_hcd *hcd, struct usb_device *udev, int r);
};
#define XHCI_CFC_DELAY 10
--
2.37.1.595.g718a3a8f04-goog
next prev parent reply other threads:[~2022-08-16 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 8:38 [PATCH 0/2] Provide a hook to check port init status Ray Chi
2022-08-16 8:38 ` [PATCH 1/2] usb: core: add " Ray Chi
2022-08-16 13:53 ` Alan Stern
2022-08-16 8:38 ` Ray Chi [this message]
2022-08-16 8:57 ` [PATCH 2/2] usb: xhci: add check_init_status hook support Greg KH
2022-08-22 15:42 ` Ray Chi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816083854.1491886-3-raychi@google.com \
--to=raychi@google.com \
--cc=albertccwang@google.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox