public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Asmaa Mnebhi <asmaa@nvidia.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Asmaa Mnebhi <asmaa@nvidia.com>, Khalil Blaiech <kblaiech@nvidia.com>
Subject: [PATCH v1 4/7] i2c-mlxbf.c: incorrect base address passed during io write
Date: Tue, 16 Aug 2022 18:54:09 -0400	[thread overview]
Message-ID: <20220816225412.9095-5-asmaa@nvidia.com> (raw)
In-Reply-To: <20220816225412.9095-1-asmaa@nvidia.com>

Correct base address used during io write.

Reviewed-by: Khalil Blaiech <kblaiech@nvidia.com>
Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
---
 drivers/i2c/busses/i2c-mlxbf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c
index 39051c4a6db2..02ed6983c35c 100644
--- a/drivers/i2c/busses/i2c-mlxbf.c
+++ b/drivers/i2c/busses/i2c-mlxbf.c
@@ -655,7 +655,7 @@ static int mlxbf_i2c_smbus_enable(struct mlxbf_i2c_priv *priv, u8 slave,
 	/* Clear status bits. */
 	writel(0x0, priv->smbus->io + MLXBF_I2C_SMBUS_MASTER_STATUS);
 	/* Set the cause data. */
-	writel(~0x0, priv->smbus->io + MLXBF_I2C_CAUSE_OR_CLEAR);
+	writel(~0x0, priv->mst_cause->io + MLXBF_I2C_CAUSE_OR_CLEAR);
 	/* Zero PEC byte. */
 	writel(0x0, priv->smbus->io + MLXBF_I2C_SMBUS_MASTER_PEC);
 	/* Zero byte count. */
-- 
2.30.1


  parent reply	other threads:[~2022-08-16 23:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 22:54 [PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 1/7] i2c-mlxbf.c: Fix frequency calculation Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 2/7] i2c-mlxbf.c: remove IRQF_ONESHOT Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 3/7] i2c-mlxbf: add multi slave functionality Asmaa Mnebhi
2022-08-18 16:25   ` Wolfram Sang
2022-08-18 16:41     ` Asmaa Mnebhi
2022-08-16 22:54 ` Asmaa Mnebhi [this message]
2022-08-18 16:27   ` [PATCH v1 4/7] i2c-mlxbf.c: incorrect base address passed during io write Wolfram Sang
2022-08-18 16:40     ` Asmaa Mnebhi
2022-08-18 17:21       ` Asmaa Mnebhi
2022-08-18 20:24         ` Wolfram Sang
2022-08-18 20:30           ` Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 5/7] i2c-mlxbf: prevent stack overflow in mlxbf_i2c_smbus_start_transaction() Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 6/7] i2c-mlxbf.c: support BlueField-3 SoC Asmaa Mnebhi
2022-08-18 15:11   ` Rob Herring
2022-08-18 20:43     ` Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 7/7] i2c-mlxbf.c: support lock mechanism Asmaa Mnebhi
2022-08-18 16:24 ` [PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support Wolfram Sang
2022-08-18 16:42   ` Asmaa Mnebhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220816225412.9095-5-asmaa@nvidia.com \
    --to=asmaa@nvidia.com \
    --cc=kblaiech@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox