From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B50C00140 for ; Thu, 18 Aug 2022 16:48:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345094AbiHRQsY (ORCPT ); Thu, 18 Aug 2022 12:48:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345059AbiHRQrx (ORCPT ); Thu, 18 Aug 2022 12:47:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C21F6C697E for ; Thu, 18 Aug 2022 09:47:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2118861616 for ; Thu, 18 Aug 2022 16:47:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E37F9C433D6; Thu, 18 Aug 2022 16:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660841244; bh=TOzmBUEyJkFq8BX4F3WOSMODGQe0Ba5ENH0sx85QamI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LLH25lEpgr2dMgoKRLVa5sV7uD7QbcSjlsoML0BE3YJgHOw4bNv18wV4xwemwNYk9 6AJSWHFQ3vI+SyxlslrKJMcJZvFMtVZTC/PToXpElifvn3YClsfz2AoPwJGPTBN3+Q Y01N1HFicGjAzSz2/d0KuYOtCW88ctTocyT+GOMUapTOtnTdjAJs/hPv56bFWXeYe0 o1MJU2aAX0xWqoM50OayLwwNOACLQr1oTMuKIT9PdbQhW+5tbGpWjpeYWdTUEa64Gp F/f53FsfZZxzfwALuucn9/9j3vkb227bGsx4kUb+w44cVfy0naZIkS8mlZAiTyUqME ZZFxmfPs/e4jA== From: SeongJae Park To: Baolin Wang Cc: sj@kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev, mike.kravetz@oracle.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/damon: replace pmd_huge() with pmd_trans_huge() for THP Date: Thu, 18 Aug 2022 16:47:22 +0000 Message-Id: <20220818164722.51448-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baolin, On Thu, 18 Aug 2022 15:37:44 +0800 Baolin Wang wrote: > The pmd_huge() is usually used to indicate if a pmd level hugetlb, > however a pmd mapped huge page can only be THP in damon_mkold_pmd_entry() > or damon_young_pmd_entry(), so replacing pmd_huge() with pmd_trans_huge() > in this case to make code more readable according to the discussion [1]. Thanks to Baolin and Muchun for the discussion and this patch! > > [1] https://lore.kernel.org/all/098c1480-416d-bca9-cedb-ca495df69b64@linux.alibaba.com/ > > Signed-off-by: Baolin Wang Reviewed-by: SeongJae Park Thanks, SJ [...]