From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Huang Rui <ray.huang@amd.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
Tim Huang <Tim.Huang@amd.com>
Subject: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:139 smu_set_gfx_power_up_by_imu() error: we previously assumed 'smu->ppt_funcs' could be null (see line 139)
Date: Mon, 22 Aug 2022 09:42:53 +0300 [thread overview]
Message-ID: <202208190418.1Y3QCIis-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 573ae4f13f630d6660008f1974c0a8a29c30e18a
commit: 7101ab97e3b00ec1c68d09826bb0521d17783673 drm/amdgpu/pm: implement the SMU_MSG_EnableGfxImu function
config: ia64-randconfig-m031-20220814 (https://download.01.org/0day-ci/archive/20220819/202208190418.1Y3QCIis-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:139 smu_set_gfx_power_up_by_imu() error: we previously assumed 'smu->ppt_funcs' could be null (see line 139)
vim +139 drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 137 int smu_set_gfx_power_up_by_imu(struct smu_context *smu)
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 138 {
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 @139 if (!smu->ppt_funcs && !smu->ppt_funcs->set_gfx_power_up_by_imu)
^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be ||. If smu->ppt_funcs is NULL the code will crash.
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 140 return -EOPNOTSUPP;
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 141
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 142 return smu->ppt_funcs->set_gfx_power_up_by_imu(smu);
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 143 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-08-22 6:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208190418.1Y3QCIis-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=Tim.Huang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox