Re: [PATCH v2] driver core: Fix bus_type.match() error handling

Isaac Manjarres
2022-08-16T17:13:47Z

On Tue, Aug 16, 2022 at 04:13:11AM -0700, Guenter Roeck wrote:
> On Mon, Aug 15, 2022 at 10:17:23PM -0700, Isaac Manjarres wrote:
> > On Mon, Aug 15, 2022 at 09:25:07PM -0700, Guenter Roeck wrote:
> > > > v1 -> v2:
> > > > - Fixed the logic in __driver_attach() to allow a driver to continue
> > > > attempting to match and bind with devices in case of any error, not
> > > > just probe deferral.
> > > >
> > > > Guenter,
> > > >
> > > > Can you please give test this patch to make sure it still works for you?
> > > >
> > >
> > > Not as well as v1. I still see the clk crash with versatileab, and imx25-pdk
> > > emulations now stall during boot when trying to boot from usb.
> > >
> > > Guenter
> > Thanks for trying the patch out. This patch isn't meant to fix the clk
> > crash that you mentioned on another thread. I had made the following patch for
> > that: https://lore.kernel.org/lkml/YvqTvuqSll30Rv2k@google.com/. Have
> > you been able to give that a shot yet? If not can you please test with the
> > patch in this e-mail and that patch?
> >
>
> No, sorry, I missed that one. It does not apply, though - it is whitespace
> corrupted. I tried to fix it up, but that failed.

When applying the patch, can you please try with
git apply --ignore-whitespace ? That worked for me.
>
> > Did you test imx25-pdk emulations with just v1 of this patch previously?
> >
>
> I am quite sure I did because it is a single setup.
>
That's odd. Is this something that I can try out on qemu? If so, can you
please share the qemu commandline so I can take a look?

Thanks,
Isaac