* [PATCH v4] clk: tegra: Add missing of_node_put()
@ 2022-06-17 1:59 Liang He
2022-08-19 21:30 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-06-17 1:59 UTC (permalink / raw)
To: pdeschrijver, pgaikwad, mturquette, sboyd, thierry.reding,
jonathanh
Cc: linux-clk, linux-tegra, linux-kernel, Liang He
In tegra124_132_clock_init_pre() and tegra30_clock_init(),
of_find_matching_node() will return a node pointer with
refcount incremented. We should use of_node_put() when it
is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
changelog:
v4: split v3 into nomadik and tegra
v3: merge clk 'missing of_node_put()' patches into one commit.
v2: use Liang He as real name for S-o-b.
v1: fix the missing of_node_put().
drivers/clk/tegra/clk-tegra124.c | 1 +
drivers/clk/tegra/clk-tegra30.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
index 934520aab6e3..a9d4efcef2d4 100644
--- a/drivers/clk/tegra/clk-tegra124.c
+++ b/drivers/clk/tegra/clk-tegra124.c
@@ -1471,6 +1471,7 @@ static void __init tegra124_132_clock_init_pre(struct device_node *np)
}
pmc_base = of_iomap(node, 0);
+ of_node_put(node);
if (!pmc_base) {
pr_err("Can't map pmc registers\n");
WARN_ON(1);
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index 04b496123820..168c07d5a5f2 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -1320,6 +1320,7 @@ static void __init tegra30_clock_init(struct device_node *np)
}
pmc_base = of_iomap(node, 0);
+ of_node_put(node);
if (!pmc_base) {
pr_err("Can't map pmc registers\n");
BUG();
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] clk: tegra: Add missing of_node_put()
2022-06-17 1:59 [PATCH v4] clk: tegra: Add missing of_node_put() Liang He
@ 2022-08-19 21:30 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2022-08-19 21:30 UTC (permalink / raw)
To: Liang He, jonathanh, mturquette, pdeschrijver, pgaikwad,
thierry.reding
Cc: linux-clk, linux-tegra, linux-kernel, Liang He
Quoting Liang He (2022-06-16 18:59:18)
> In tegra124_132_clock_init_pre() and tegra30_clock_init(),
> of_find_matching_node() will return a node pointer with
> refcount incremented. We should use of_node_put() when it
> is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-19 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-17 1:59 [PATCH v4] clk: tegra: Add missing of_node_put() Liang He
2022-08-19 21:30 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox