Re: [PATCH 4/7] kernfs: Skip kernfs_drain_open_files() more aggressively

Tejun Heo
2022-08-23T20:17:29Z

On Tue, Aug 23, 2022 at 01:27:22PM +0800, Chengming Zhou wrote:
> > + if (of) {
> > + WARN_ON_ONCE((kn->flags & KERNFS_HAS_RELEASE) && !of->released);
>
> kernfs_unlink_open_file() is also used in error case "err_put_node" in kernfs_fop_open(),
> which should also dec the on->nr_to_release?

Ah, right you're. Will fix. Thanks for pointing it out.

--
tejun