From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20B6C25B08 for ; Sat, 20 Aug 2022 06:56:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245389AbiHTG41 (ORCPT ); Sat, 20 Aug 2022 02:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245437AbiHTG4M (ORCPT ); Sat, 20 Aug 2022 02:56:12 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54969C0B6B for ; Fri, 19 Aug 2022 23:56:10 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id u14so6987433oie.2 for ; Fri, 19 Aug 2022 23:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=SQLEV3ZJdsSTEKNxjgfsvOWLI34f1G/vgTOHGNz1ESU=; b=KfEegITjib3KDK815XP3VzvFhA6icKjuLs09g/yTqCf6xaSL2mqu99L/+L8fj6PC5a b8tbrdfYgZckjz3uiONGIjghGAyNwqkDI55kXSSHRH2sCjT4Ke8lfBk5kiAKKXxFakG+ xwsZuz1CdE3wMwcrrqy5S41Nm3D8VifKjYYY7svKwAwwNVfL8zAH9ZlLv8IbY4XbgQOR yXA9Gz3UbwWWA3OgCZTptkbRlQIkmd0ZzAiC+SPQFqtvpEhO2uc9RnQwGx766FCNTcmf uhrZyLmlpSIad69tow/AxXRW2s+GqVzfzHEaLErauRcfTZIOjk921WNjOWzgb5UVig6Q Wa8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=SQLEV3ZJdsSTEKNxjgfsvOWLI34f1G/vgTOHGNz1ESU=; b=gflyV+GZptEmOKbk1m9Rp09qWQAFAQwwh8USsk797vDO9jM50dqlFzoUdnIZYw6dlj Pvac6dfr3b02e20ww23r5ftp3INk1YV5QqS0BEdIuRA4A67o4YnCeG9voRstakIo+CcK SduX3UiFYPv8jt/kkW3dK8bcJy04B15NL2syZgb9vxOU1x9qVjwkGEXakh9ho++2z09y GfXGcQxryfUyZ9kxfPL9ZO/4Hs5xH7+u+Y53A+VUA1lD5yvAyp5bsIHjTvrjKYV/LtU2 yV1G6DipDwovaSA8Cwbe5iPrbeSsw8dvAHDH6zVQNO+3TCfiUpB19hHEJ3dqOzXzMRdJ yChg== X-Gm-Message-State: ACgBeo02Uoe8LIirbgH1CDCBIK71knoZEDf+MlHl48dBCP3DfiAgb4JT dnWIVAjB0upy25AnMzye6C6TFA== X-Google-Smtp-Source: AA6agR72R5W/Kex/XQuCupNMmzaZixN6xlaEo5/RRm3bBS76PuHWKeKoMW9NiLcn+wuJrVWPuvXKYQ== X-Received: by 2002:a05:6808:295:b0:344:eccd:3fd6 with SMTP id z21-20020a056808029500b00344eccd3fd6mr7807774oic.2.1660978569430; Fri, 19 Aug 2022 23:56:09 -0700 (PDT) Received: from anup-ubuntu64-vm.. ([171.76.82.68]) by smtp.gmail.com with ESMTPSA id h26-20020a9d641a000000b00636faf5e2d9sm1661098otl.39.2022.08.19.23.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 23:56:08 -0700 (PDT) From: Anup Patel To: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Daniel Lezcano Cc: Atish Patra , Alistair Francis , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel Subject: [PATCH v8 5/7] RISC-V: Allow marking IPIs as suitable for remote FENCEs Date: Sat, 20 Aug 2022 12:24:44 +0530 Message-Id: <20220820065446.389788-6-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220820065446.389788-1-apatel@ventanamicro.com> References: <20220820065446.389788-1-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To do remote FENCEs (i.e. remote TLB flushes) using IPI calls on the RISC-V kernel, we need hardware mechanism to directly inject IPI from the supervisor mode (i.e. RISC-V kernel) instead of using SBI calls. The upcoming AIA IMSIC devices allow direct IPI injection from the supervisor mode (i.e. RISC-V kernel). To support this, we extend the riscv_ipi_set_virq_range() function so that IPI provider (i.e. irqchip drivers can mark IPIs as suitable for remote FENCEs. Signed-off-by: Anup Patel --- arch/riscv/include/asm/smp.h | 18 ++++++++++++++++-- arch/riscv/kernel/sbi-ipi.c | 2 +- arch/riscv/kernel/smp.c | 11 ++++++++++- drivers/clocksource/timer-clint.c | 2 +- 4 files changed, 28 insertions(+), 5 deletions(-) diff --git a/arch/riscv/include/asm/smp.h b/arch/riscv/include/asm/smp.h index 79ed0b73cd4e..56976e41a21e 100644 --- a/arch/riscv/include/asm/smp.h +++ b/arch/riscv/include/asm/smp.h @@ -16,6 +16,9 @@ struct seq_file; extern unsigned long boot_cpu_hartid; #ifdef CONFIG_SMP + +#include + /* * Mapping between linux logical cpu index and hartid. */ @@ -46,7 +49,12 @@ void riscv_ipi_disable(void); bool riscv_ipi_have_virq_range(void); /* Set the IPI interrupt numbers for arch (called by irqchip drivers) */ -void riscv_ipi_set_virq_range(int virq, int nr); +void riscv_ipi_set_virq_range(int virq, int nr, bool use_for_rfence); + +/* Check if we can use IPIs for remote FENCEs */ +DECLARE_STATIC_KEY_FALSE(riscv_ipi_for_rfence); +#define riscv_use_ipi_for_rfence() \ + static_branch_unlikely(&riscv_ipi_for_rfence) /* Secondary hart entry */ asmlinkage void smp_callin(void); @@ -93,10 +101,16 @@ static inline bool riscv_ipi_have_virq_range(void) return false; } -static inline void riscv_ipi_set_virq_range(int virq, int nr) +static inline void riscv_ipi_set_virq_range(int virq, int nr, + bool use_for_rfence) { } +static inline bool riscv_use_ipi_for_rfence(void) +{ + return false; +} + #endif /* CONFIG_SMP */ #if defined(CONFIG_HOTPLUG_CPU) && (CONFIG_SMP) diff --git a/arch/riscv/kernel/sbi-ipi.c b/arch/riscv/kernel/sbi-ipi.c index 0bb070a5dcb4..27fdc394d2f0 100644 --- a/arch/riscv/kernel/sbi-ipi.c +++ b/arch/riscv/kernel/sbi-ipi.c @@ -55,6 +55,6 @@ void __init sbi_ipi_init(void) return; } - riscv_ipi_set_virq_range(virq, BITS_PER_BYTE); + riscv_ipi_set_virq_range(virq, BITS_PER_BYTE, false); pr_info("providing IPIs using SBI IPI extension\n"); } diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c index e25d39cd2d27..cb2bda4822de 100644 --- a/arch/riscv/kernel/smp.c +++ b/arch/riscv/kernel/smp.c @@ -143,7 +143,10 @@ bool riscv_ipi_have_virq_range(void) return (ipi_virq_base) ? true : false; } -void riscv_ipi_set_virq_range(int virq, int nr) +DEFINE_STATIC_KEY_FALSE(riscv_ipi_for_rfence); +EXPORT_SYMBOL_GPL(riscv_ipi_for_rfence); + +void riscv_ipi_set_virq_range(int virq, int nr, bool use_for_rfence) { int i, err; @@ -166,6 +169,12 @@ void riscv_ipi_set_virq_range(int virq, int nr) /* Enabled IPIs for boot CPU immediately */ riscv_ipi_enable(); + + /* Update RFENCE static key */ + if (use_for_rfence) + static_branch_enable(&riscv_ipi_for_rfence); + else + static_branch_disable(&riscv_ipi_for_rfence); } EXPORT_SYMBOL_GPL(riscv_ipi_set_virq_range); diff --git a/drivers/clocksource/timer-clint.c b/drivers/clocksource/timer-clint.c index ac7c2caaa65a..f418816fd706 100644 --- a/drivers/clocksource/timer-clint.c +++ b/drivers/clocksource/timer-clint.c @@ -246,7 +246,7 @@ static int __init clint_timer_init_dt(struct device_node *np) goto fail_remove_cpuhp; } - riscv_ipi_set_virq_range(virq, BITS_PER_BYTE); + riscv_ipi_set_virq_range(virq, BITS_PER_BYTE, true); clint_clear_ipi(clint_ipi_irq, NULL); return 0; -- 2.34.1