From: "Christian Kohlschütter" <christian@kohlschutter.com>
To: Matthias Kaehlcke <mka@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: "Christian Kohlschütter" <christian@kohlschutter.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] regulator: core: Remove "ramp_delay not set" debug message
Date: Sat, 20 Aug 2022 12:24:54 +0000 [thread overview]
Message-ID: <20220820122453.13071-1-christian@kohlschutter.com> (raw)
This message shows up occasionally but in bursts (seen as up 30 times
per second on my ODROID N2+).
According to Matthias Kaehlcke's comment in 'regulator: core: silence
warning: "VDD1: ramp_delay not set"', this message should have been
removed after restructuring previous code that assumed that ramp_delay
being zero in that function was an error.
Link: https://lore.kernel.org/lkml/625675256c0d75805f088b4be17a3308dc1b7ea4.1477571498.git.hns@goldelico.com/T/
Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
---
drivers/regulator/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index a5033c6ba01..18fa9206ec2 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3497,10 +3497,8 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev,
(new_uV < old_uV))
return rdev->constraints->settling_time_down;
- if (ramp_delay == 0) {
- rdev_dbg(rdev, "ramp_delay not set\n");
+ if (ramp_delay == 0)
return 0;
- }
return DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay);
}
--
2.36.2
next reply other threads:[~2022-08-20 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 12:24 Christian Kohlschütter [this message]
2022-08-20 13:14 ` [PATCH v2] regulator: core: Remove "ramp_delay not set" debug message Christian Kohlschütter
2022-08-22 15:45 ` [PATCH] " Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220820122453.13071-1-christian@kohlschutter.com \
--to=christian@kohlschutter.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox