From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <olsajiri@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [BUG v6.0-rc2] lockdep splat on ct_kernel_enter()
Date: Mon, 22 Aug 2022 22:01:34 -0400 [thread overview]
Message-ID: <20220822220134.5d91f3db@rorschach.local.home> (raw)
In-Reply-To: <20220822214024.216fa85d@rorschach.local.home>
On Mon, 22 Aug 2022 21:40:24 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> And this patch (which is wrong, but will at least let my tests finish
> testing my code) makes the warning go away.
Well that patch was against the broken commit, but this patch against
6.0-rc2 works for me, albeit, it's still wrong ;-)
-- Steve
diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
index 77978e372377..17201159f3df 100644
--- a/kernel/context_tracking.c
+++ b/kernel/context_tracking.c
@@ -330,13 +330,13 @@ EXPORT_SYMBOL_GPL(ct_idle_enter);
* If you add or remove a call to ct_idle_exit(), be sure to test with
* CONFIG_RCU_EQS_DEBUG=y.
*/
-void noinstr ct_idle_exit(void)
+void ct_idle_exit(void)
{
unsigned long flags;
- raw_local_irq_save(flags);
+ local_irq_save(flags);
ct_kernel_enter(false, RCU_DYNTICKS_IDX - CONTEXT_IDLE);
- raw_local_irq_restore(flags);
+ local_irq_restore(flags);
}
EXPORT_SYMBOL_GPL(ct_idle_exit);
next prev parent reply other threads:[~2022-08-23 2:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 20:44 [BUG v6.0-rc2] lockdep splat on ct_kernel_enter() Steven Rostedt
2022-08-22 22:28 ` Steven Rostedt
2022-08-22 22:38 ` Steven Rostedt
2022-08-23 0:48 ` Steven Rostedt
2022-08-23 1:40 ` Steven Rostedt
2022-08-23 2:01 ` Steven Rostedt [this message]
2022-08-23 2:36 ` Paul E. McKenney
2023-03-01 12:37 ` Cheng-Jui Wang (王正睿)
2023-03-01 12:52 ` gregkh
2023-03-02 3:42 ` Cheng-Jui Wang (王正睿)
2023-03-02 6:42 ` gregkh
2023-03-01 14:14 ` Frederic Weisbecker
2023-03-01 20:15 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822220134.5d91f3db@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olsajiri@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox