Re: [PATCH 5.4 182/389] PCI/portdrv: Dont disable AER reporting in get_port_device_capability()

Greg Kroah-Hartman
2022-09-01T11:08:59Z

On Wed, Aug 31, 2022 at 07:52:00AM +0200, Stefan Roese wrote:
> On 31.08.22 00:11, Bjorn Helgaas wrote:
> > [+cc Gregory, linux-wireless for iwlwifi issue]
> >
> > On Tue, Aug 30, 2022 at 01:47:48PM -0700, Ben Greear wrote:
> > > On 8/23/22 11:41 PM, Greg Kroah-Hartman wrote:
> > > > On Tue, Aug 23, 2022 at 07:20:14AM -0500, Bjorn Helgaas wrote:
> > > > > On Tue, Aug 23, 2022, 6:35 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > wrote:
> > > > >
> > > > > > From: Stefan Roese <sr@denx.de>
> > > > > >
> > > > > > [ Upstream commit 8795e182b02dc87e343c79e73af6b8b7f9c5e635 ]
> > > > > >
> > > > >
> > > > > There's an open regression related to this commit:
> > > > >
> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=216373
> > > >
> > > > This is already in the following released stable kernels:
> > > > 5.10.137 5.15.61 5.18.18 5.19.2
> > > >
> > > > I'll go drop it from the 4.19 and 5.4 queues, but when this gets
> > > > resolved in Linus's tree, make sure there's a cc: stable on the fix so
> > > > that we know to backport it to the above branches as well. Or at the
> > > > least, a "Fixes:" tag.
> > >
> > > This is still in 5.19.5. We saw some funny iwlwifi crashes in 5.19.3+
> > > that we did not see in 5.19.0+. I just bisected the scary looking
> > > AER errors to this patch, though I do not know for certain if it
> > > causes the iwlwifi related crashes yet.
> > >
> > > In general, from reading the commit msg, this patch doesn't seem to
> > > be a great candidate for stable in general. Does it fix some
> > > important problem?
> >
> > I agree, I don't think this is a good candidate for stable. It has
> > already exposed latent amdgpu issues and we'll likely find more. It's
> > good to find and fix these things, but I'd rather do it in -rc than in
> > stable kernels.
>
> I also agree. It was not my intention to have this patch added to
> the stable branches. Frankly I missed intervening when seeing the
> mails about the integration into stable a few weeks ago.

It was maked with a Fixes: tag, which makes it ripe for backporting,
especially as it is written as "this fixes this problem".

Anyway, I've now reverted it from the stable trees. Hopefully you all
get this figured out so that 6.0 doesn't have the same issue.

thanks,

greg k-h